You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there are two problems the media ui tries to solve with their hack:
the styles in import '@fortawesome/fontawesome-svg-core/styles.css'; are originally prefixed with svg-inline--fa but in the big ui bundle we go extra legths to ensure encapsulation (do we need to?) by prefixing it in the build with neos-
and we also modify font awesome to use our neos prefix. But when using the react-ui-components externally you dont want to have that extra css replace step in place.
using the has a sideeffect and all fontawesome icons are bundled into your package (what you might not like if you at least a little care about bundle size ^^)
The text was updated successfully, but these errors were encountered:
see what the media-ui is doing:
https://github.com/Flowpack/media-ui/blob/38ca2f09d9c345c64bbf77d3655ea9bb3eb56da1/patches/@neos-project+react-ui-components+5.3.13.patch
https://github.com/Flowpack/media-ui/blob/38ca2f09d9c345c64bbf77d3655ea9bb3eb56da1/Resources/Private/JavaScript/media-module/src/lib/FontAwesome.ts#L59-L63
there are two problems the media ui tries to solve with their hack:
import '@fortawesome/fontawesome-svg-core/styles.css';
are originally prefixed withsvg-inline--fa
but in the big ui bundle we go extra legths to ensure encapsulation (do we need to?) by prefixing it in the build withneos-
neos-ui/esbuild.js
Lines 63 to 73 in 5e7ae4a
The text was updated successfully, but these errors were encountered: