You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: repositories/neovim/issues/19624.json
+57-7Lines changed: 57 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -3381,9 +3381,54 @@
3381
3381
"url": "https://api.github.com/users/vurentjie",
3382
3382
"user_view_type": "public"
3383
3383
}
3384
+
},
3385
+
{
3386
+
"author_association": "CONTRIBUTOR",
3387
+
"body": "Hi,\n\nI would like to present my design for structured concurrency in Neovim: [Coop.nvim](https://github.com/gregorias/coop.nvim). I believe it addresses all requirements you have listed out for such a framework + it’s as straightforward as such a framework could be ([How it works doc](https://github.com/gregorias/coop.nvim/blob/main/How%20it%20works.md)). I believe it provides an elegant approach to the subject.\n\nHere’s how Coop relates to the listed requirements:\n\n> Representing a task.\n> Orchestrating \"pipelines\" (quasi monads?) of work (\"tasks\") and handling errors.\n\n[See examples](https://github.com/gregorias/coop.nvim/blob/0e2082500707f2a143ff924ad36577c348148517/lua/coop/examples.lua#L72) for examples of handling errors, running tasks in parallel, and complex awaiting conditions.\n\n> Maximally leveraging Lua coroutines + libuv. Only add concepts (\"task\", \"promise\") if absolutely needed.\n\nYes,\n\n- the Task interface is an extension to Lua coroutines and implements parallel `create, resume, yield, status` functions with equivalent semantics.\n- Libuv functions are easily ported through generic wrappers: https://github.com/gregorias/coop.nvim/blob/main/lua/coop/uv.lua.\n- Only two concepts are added: a task and a future.\n\n> Coroutines (or tasks that wrap coroutines) can be nested. ([ref](https://gregorias.github.io/posts/using-coroutines-in-neovim-lua/#addendum-whats-wrong-with-plenary-async))\n\nTrue. In Coop you can freely nest task functions (a task function is a function that may call `task.yield`).\n\n> Util to create an awaitable task from \"normal\" functions (cf. \"promisify\"?).\n> Example: vim.system() returns its own ad-hoc \"task\" that can be \"awaited\" via :wait().\n> Can e.g. vim.system() be \"promisified\" without its knowledge?\n\nCoop indeed “promisifies” `uv.spawn`. Coop’s implementation returns an awaitable future. [In tests you have an example of how it turns the callback interface from Neovim’s documentation into a synchronous one](https://github.com/gregorias/coop.nvim/blob/ff49c6d5a741e9e7b22366f5bedf43f7fcfd01c5/tests/coop/uv_spec.lua#L48-L84):\n\n```lua\nlocal stdin = vim.uv.new_pipe()\nlocal stdout = vim.uv.new_pipe()\nlocal stderr = vim.uv.new_pipe()\n\nlocal handle, pid, cat_future = uv.spawn(\"cat\", {\n\tstdio = { stdin, stdout, stderr },\n})\n\nlocal read_future = coop.Future.new()\nvim.uv.read_start(stdout, function(err, data)\n\tassert(not err, err)\n\tif data ~= nil and not read_future.done then\n\t\tread_future:complete(data)\n\tend\nend)\nvim.uv.write(stdin, \"Hello World\")\n\n-- Here we wrap the APIs into a task to use the synchronous looking interface.\nlocal task = coop.spawn(function()\n\t-- Wait for stdout to produce the data.\n\tlocal read_data = read_future:await()\n\tassert.are.same(\"Hello World\", read_data)\n\tlocal err_stdin_shutdown = uv.shutdown(stdin)\n\tassert.is.Nil(err_stdin_shutdown)\n\t-- Wait for the cat process to finish.\n\treturn cat_future:await()\nend)\n\n-- Wait for 200ms for the task finish.\nlocal exit_code, exit_sign = task:await(200, 2)\n```\n\n> Document (or generalize) [\"coroutine to callback\"](https://gregorias.github.io/posts/using-coroutines-in-neovim-lua/#coroutine-to-callback-conversion).\n\nCoop provides a generic converter callback to coroutine converter: `cb_to_tf` ([docs](https://github.com/gregorias/coop.nvim/blob/main/How%20it%20works.md#using-callbacks-to-build-coroutines).)\n\nThe generic conversion from a coroutine (a task) into a callback is done through [an await overload that accepts a callback](https://github.com/gregorias/coop.nvim/tree/main#:~:text=task.await(function(success%2C%20result)%20end)).\n\n> await_all, await_any (pseudo-names). See JS [Promise.all()](https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Promise/all).\n> Results (and failures) can be aggregated. (Can't do this with jobwait()!)\n\nAll possible. For example, Coop provides an implementation of `as_completed`, an iterator that returns task results as they finish: [example](https://github.com/gregorias/coop.nvim/tree/main#:~:text=sort_with_time%20shows%20that%20Coop%20achieves%20true%20parallelism.%20It%20launches%20parallel%20timers%20with%20coop.spawn%20and%20uses%20a%20coop.control.as_completed%20to%20conveniently%20capture%20results%20as%20each%20timer%20completes.).\n\nTentative implementations of `await_all` and `await_any` are in [control.lua](https://github.com/gregorias/coop.nvim/blob/ff49c6d5a741e9e7b22366f5bedf43f7fcfd01c5/lua/coop/control.lua#L1-L68).\n\n> Tasks can be canceled.\n\n[True.](https://github.com/gregorias/coop.nvim/blob/main/How%20it%20works.md#cancellation)\n\n> Failures/errors can be handled\n\n[True.](https://github.com/gregorias/coop.nvim/blob/main/How%20it%20works.md#error-handling)\n\n> (possibly canceling the rest of the task tree).\n\nCoop doesn’t natively provide the task tree abstraction to keep with the Lua’s spirit of coroutines being standalone threads. Task trees can be implemented on top of Coop, because the programmer can intercept the `\"cancelled\"` error and `:cancel` subtasks.",
Copy file name to clipboardExpand all lines: repositories/neovim/issues/20310.json
+47-15Lines changed: 47 additions & 15 deletions
Original file line number
Diff line number
Diff line change
@@ -4,7 +4,28 @@
4
4
"assignees": [],
5
5
"author_association": "MEMBER",
6
6
"body": "### Feature already in Vim?\n\n_No response_\n\n### Feature description\n\nWhen using `ext_messages`, I found no easy way to retrieve highlight attributes. `ext_hlstate` looks promising, but doesn't seem to be available within lua.\r\n\r\nWould be great if there would be an API call to retrieve the HL attributes.\r\n\r\nCurrent workaround I found by @notomo:\r\n\r\n```lua\r\nlocal M = {}\r\n\r\nfunction M.setup()\r\n local ffi = require(\"ffi\")\r\n local ok, err = pcall(\r\n ffi.cdef,\r\n [[typedef int32_t RgbValue;\r\n typedef struct attr_entry {\r\n int16_t rgb_ae_attr, cterm_ae_attr;\r\n RgbValue rgb_fg_color, rgb_bg_color, rgb_sp_color;\r\n int cterm_fg_color, cterm_bg_color;\r\n int hl_blend;\r\n } HlAttrs;\r\n HlAttrs syn_attr2entry(int attr);]]\r\n )\r\n if not ok and not err:find(\"redefine\") then\r\n error(err)\r\n end\r\n M.attr2entry = ffi.C.syn_attr2entry\r\nend\r\n\r\nfunction M.attr2entry(attr_id)\r\n M.setup()\r\n return M.attr2entry(attr_id)\r\nend\r\n\r\nM.cache = {}\r\n\r\nfunction M.get_hl_group(attr_id)\r\n return \"NoiceAttr\" .. tostring(attr_id)\r\nend\r\n\r\nfunction M.get_hl(attr_id)\r\n if not M.cache[attr_id] then\r\n local attrs = M.attr2entry(attr_id)\r\n local hl_group = M.get_hl_group(attr_id)\r\n vim.api.nvim_set_hl(0, hl_group, {\r\n fg = attrs.rgb_fg_color,\r\n bg = attrs.rgb_bg_color,\r\n sp = attrs.rgb_sp_color,\r\n bold = bit.band(attrs.rgb_ae_attr, 0x02),\r\n standout = bit.band(attrs.rgb_ae_attr, 0x0100),\r\n italic = bit.band(attrs.rgb_ae_attr, 0x04),\r\n underline = bit.band(attrs.rgb_ae_attr, 0x08),\r\n undercurl = bit.band(attrs.rgb_ae_attr, 0x10),\r\n nocombine = bit.band(attrs.rgb_ae_attr, 0x0200),\r\n reverse = bit.band(attrs.rgb_ae_attr, 0x01),\r\n blend = attrs.hl_blend ~= -1 and attrs.hl_blend or nil,\r\n })\r\n M.cache[attr_id] = hl_group\r\n end\r\n return M.cache[attr_id]\r\nend\r\n\r\nreturn M\r\n```",
0 commit comments