Skip to content

Commit c853519

Browse files
Use kwargs instead of empty hash argument
1 parent 507a965 commit c853519

File tree

1 file changed

+9
-12
lines changed
  • lib/polyphony/extensions

1 file changed

+9
-12
lines changed

lib/polyphony/extensions/io.rb

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,51 +27,48 @@ def binwrite(name, string, offset = nil)
2727
end
2828
end
2929

30-
# @!visibility private
31-
EMPTY_HASH = {}.freeze
32-
3330
# @!visibility private
3431
alias_method :orig_foreach, :foreach
3532

3633
# @!visibility private
37-
def foreach(name, sep = $/, limit = nil, getline_args = EMPTY_HASH, &block)
34+
def foreach(name, sep = $/, limit = nil, **kwargs, &block)
3835
if sep.is_a?(Integer)
3936
sep = $/
4037
limit = sep
4138
end
4239
File.open(name, 'r') do |f|
43-
f.each_line(sep, limit, chomp: getline_args[:chomp], &block)
40+
f.each_line(sep, limit, chomp: kwargs[:chomp], &block)
4441
end
4542
end
4643

4744
# @!visibility private
4845
alias_method :orig_read, :read
4946

5047
# @!visibility private
51-
def read(name, length = nil, offset = nil, opt = EMPTY_HASH)
48+
def read(name, length = nil, offset = nil, **kwargs)
5249
if length.is_a?(Hash)
53-
opt = length
50+
kwargs = length
5451
length = nil
5552
end
56-
File.open(name, opt[:mode] || 'r') do |f|
53+
File.open(name, kwargs[:mode] || 'r') do |f|
5754
f.seek(offset) if offset
5855
length ? f.read(length) : f.read
5956
end
6057
end
6158

6259
alias_method :orig_readlines, :readlines
63-
def readlines(name, sep = $/, limit = nil, getline_args = EMPTY_HASH)
60+
def readlines(name, sep = $/, limit = nil, **kwargs)
6461
File.open(name, 'r') do |f|
65-
f.readlines(sep, **getline_args)
62+
f.readlines(sep, **kwargs)
6663
end
6764
end
6865

6966
# @!visibility private
7067
alias_method :orig_write, :write
7168

7269
# @!visibility private
73-
def write(name, string, offset = nil, opt = EMPTY_HASH)
74-
File.open(name, opt[:mode] || 'w') do |f|
70+
def write(name, string, offset = nil, **kwargs)
71+
File.open(name, kwargs[:mode] || 'w') do |f|
7572
f.seek(offset) if offset
7673
f.write(string)
7774
end

0 commit comments

Comments
 (0)