Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Include RDS Proxy Metrics in the RDS namespace #1460

Open
1 task done
jfentontyro opened this issue Jul 2, 2024 · 1 comment · May be fixed by #1501
Open
1 task done

[FEATURE] Include RDS Proxy Metrics in the RDS namespace #1460

jfentontyro opened this issue Jul 2, 2024 · 1 comment · May be fixed by #1501
Labels
enhancement New feature or request

Comments

@jfentontyro
Copy link

jfentontyro commented Jul 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

RDS Proxy metrics show up in AWS under the AWS/RDS namespace in Cloudwatch Metrics.
Currently they aren't retrieved when including the relevant RDS Proxy metric name in our config under the RDS namespace with the correct search tags.

This is due to the db-proxy resource filter not being supported, given it is supported in the resourcegroupstagging api supporting this filter under the RDS namespace should allow us to retrieve these metrics

What might the configuration look like?

{
	Namespace: "AWS/RDS",
	Alias:     "rds",
	ResourceFilters: []*string{
		aws.String("rds:db"),
		aws.String("rds:cluster"),
		aws.String("rds:db-proxy"),
	},
	DimensionRegexps: []*regexp.Regexp{
		regexp.MustCompile(":cluster:(?P<DBClusterIdentifier>[^/]+)"),
		regexp.MustCompile(":db:(?P<DBInstanceIdentifier>[^/]+)"),
		regexp.MustCompile(":db-proxy:(?P<ProxyIdentifier>[^/]+)"),
	},
},

Anything else?

No response

@jfentontyro jfentontyro added the enhancement New feature or request label Jul 2, 2024
@jfentontyro
Copy link
Author

I've tested this locally and works as expected, and this passes all existing service tests.
DB proxy metrics appear in local prometheus container running against our AWS account and had no issues.
I would raise a PR for this as it's a 2 line change in the services.go file but am unable to push.

Could you have a look at this when you get a chance please @cristiangreco

vitaliyf added a commit to vitaliyf/yet-another-cloudwatch-exporter that referenced this issue Aug 16, 2024
@vitaliyf vitaliyf linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant