fix: add browsingContext as a reactive dependency to updateInternalPosition

martin-pettersson · nerdyman · commit e807bc97876c · 2024-04-05T19:55:55.000+01:00
diff --git a/lib/src/ReactCompareSlider.tsx b/lib/src/ReactCompareSlider.tsx
@@ -131,7 +131,7 @@ export const ReactCompareSlider = forwardRef<
           onPositionChange(internalPosition.current);
         }
       },
-      [boundsPadding, onPositionChange, portrait],
+      [boundsPadding, onPositionChange, portrait, browsingContext],
     );
 
     // Update internal position when other user controllable props change.

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ export const ReactCompareSlider = forwardRef<`
`131`	`131`	`onPositionChange(internalPosition.current);`
`132`	`132`	`}`
`133`	`133`	`},`
`134`		`- [boundsPadding, onPositionChange, portrait],`
	`134`	`+ [boundsPadding, onPositionChange, portrait, browsingContext],`
`135`	`135`	`);`
`136`	`136`
`137`	`137`	`// Update internal position when other user controllable props change.`