refactor(): small tweaks

Author: kamilmysliwiec

lib/mongoose.providers.ts

@@ -3,15 +3,15 @@ import { Connection, Document, Model } from 'mongoose';
 import { getConnectionToken, getModelToken } from './common/mongoose.utils';
 import {
   AsyncModelFactory,
-  ModelDefinition,
   DiscriminatorOptions,
+  ModelDefinition,
 } from './interfaces';
 
 function addDiscriminators(
   model: Model<Document>,
   discriminators: DiscriminatorOptions[] = [],
-): Model<Document>[] {
-  return discriminators.map(({ name, schema }) =>
+) {
+  discriminators.forEach(({ name, schema }) =>
     model.discriminator(name, schema),
   );
 }

tests/e2e/discriminator.spec.ts

@@ -1,14 +1,14 @@
-import { HttpStatus, INestApplication, DynamicModule } from '@nestjs/common';
+import { DynamicModule, HttpStatus, INestApplication } from '@nestjs/common';
 import { Test } from '@nestjs/testing';
 import { Server } from 'http';
 import * as request from 'supertest';
 import { MongooseModule } from '../../lib';
 import { EventModule } from '../src/event/event.module';
-import { Event, EventSchema } from '../src/event/schemas/event.schema';
 import {
-  ClieckLinkEvent,
+  ClickLinkEvent,
   ClieckLinkEventSchema,
 } from '../src/event/schemas/click-link-event.schema';
+import { Event, EventSchema } from '../src/event/schemas/event.schema';
 import {
   SignUpEvent,
   SignUpEventSchema,
@@ -22,7 +22,7 @@ const testCase: [string, DynamicModule][] = [
         name: Event.name,
         schema: EventSchema,
         discriminators: [
-          { name: ClieckLinkEvent.name, schema: ClieckLinkEventSchema },
+          { name: ClickLinkEvent.name, schema: ClieckLinkEventSchema },
           { name: SignUpEvent.name, schema: SignUpEventSchema },
         ],
       },
@@ -35,7 +35,7 @@ const testCase: [string, DynamicModule][] = [
         name: Event.name,
         useFactory: async () => EventSchema,
         discriminators: [
-          { name: ClieckLinkEvent.name, schema: ClieckLinkEventSchema },
+          { name: ClickLinkEvent.name, schema: ClieckLinkEventSchema },
           { name: SignUpEvent.name, schema: SignUpEventSchema },
         ],
       },

tests/src/event/event.controller.ts

@@ -1,9 +1,9 @@
 import { Body, Controller, Get, Post } from '@nestjs/common';
-import { EventService } from './event.service';
 import { CreateClickLinkEventDto } from './dto/create-click-link-event.dto';
 import { CreateSignUpEventDto } from './dto/create-sign-up-event.dto';
+import { EventService } from './event.service';
+import { ClickLinkEvent } from './schemas/click-link-event.schema';
 import { Event } from './schemas/event.schema';
-import { ClieckLinkEvent } from './schemas/click-link-event.schema';
 import { SignUpEvent } from './schemas/sign-up-event.schema';
 
 @Controller('event')
@@ -17,7 +17,7 @@ export class EventController {
     return this.eventService.create({
       ...dto,
       time: new Date(),
-      kind: ClieckLinkEvent.name,
+      kind: ClickLinkEvent.name,
     });
   }
 

tests/src/event/event.service.ts

@@ -3,8 +3,8 @@ import { Document, Model } from 'mongoose';
 import { InjectModel } from '../../../lib';
 import { CreateClickLinkEventDto } from './dto/create-click-link-event.dto';
 import { CreateSignUpEventDto } from './dto/create-sign-up-event.dto';
+import { ClickLinkEvent } from './schemas/click-link-event.schema';
 import { Event } from './schemas/event.schema';
-import { ClieckLinkEvent } from './schemas/click-link-event.schema';
 import { SignUpEvent } from './schemas/sign-up-event.schema';
 
 @Injectable()
@@ -13,8 +13,8 @@ export class EventService {
     @InjectModel(Event.name)
     private readonly eventModel: Model<Event & Document>,
 
-    @InjectModel(ClieckLinkEvent.name)
-    private readonly clientEventModel: Model<Event & Document>,
+    @InjectModel(ClickLinkEvent.name)
+    private readonly clickEventModel: Model<Event & Document>,
 
     @InjectModel(SignUpEvent.name)
     private readonly signUpEventModel: Model<Event & Document>,

tests/src/event/schemas/click-link-event.schema.ts

@@ -2,7 +2,7 @@ import { Prop, Schema, SchemaFactory } from '../../../../lib';
 import { Event } from './event.schema';
 
 @Schema({})
-export class ClieckLinkEvent implements Event {
+export class ClickLinkEvent implements Event {
   kind: string;
 
   time: Date;
@@ -12,5 +12,5 @@ export class ClieckLinkEvent implements Event {
 }
 
 export const ClieckLinkEventSchema = SchemaFactory.createForClass(
-  ClieckLinkEvent,
+  ClickLinkEvent,
 );

tests/src/event/schemas/event.schema.ts

@@ -1,13 +1,13 @@
 import { Prop, Schema, SchemaFactory } from '../../../../lib';
-import { ClieckLinkEvent } from './click-link-event.schema';
+import { ClickLinkEvent } from './click-link-event.schema';
 import { SignUpEvent } from './sign-up-event.schema';
 
 @Schema({ discriminatorKey: 'kind' })
 export class Event {
   @Prop({
     type: String,
     required: true,
-    enum: [ClieckLinkEvent.name, SignUpEvent.name],
+    enum: [ClickLinkEvent.name, SignUpEvent.name],
   })
   kind: string;