Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing extension of Strawberry Graphql using plugins #17242

Closed
129828 opened this issue Aug 22, 2024 · 5 comments
Closed

Allowing extension of Strawberry Graphql using plugins #17242

129828 opened this issue Aug 22, 2024 · 5 comments
Labels
netbox type: feature Introduction of new functionality to the application

Comments

@129828
Copy link

129828 commented Aug 22, 2024

NetBox version

v4.0.9

Feature type

Change to existing functionality

Proposed functionality

In previous version it was possible to extend the graphql output of existing models in netbox using a plugin. So creating a CMDB model with a OneToOneField to a dcim.device allowed it to be retrievable using either the API or GraphQL.

However, since the switch to Strawberry I cannot find how I can achieve this. There does not seem te be a way to extend existing models to allow for this.

Use case

This change would allow data to be more easily retrieved from netbox using graphql.
While it is possible to do multiple requests and merge them later this goes against the idea behind graphql that you only need 1 request.

Database changes

No response

External dependencies

No response

@129828 129828 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Aug 22, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels Jan 10, 2025
@jeremystretch
Copy link
Member

However, since the switch to Strawberry I cannot find how I can achieve this.

Should this be considered a bug as previously supported behavior has been removed?

@peteeckel
Copy link
Contributor

Should this be considered a bug as previously supported behavior has been removed?

I would strongly support that.

@sirtux
Copy link

sirtux commented Jan 11, 2025

I agree with the bug designation..

@jeremystretch
Copy link
Member

@129828 @peteeckel @sirtux could one of you please resubmit this as a bug report, citing the previously working code and any additional context that would be helpful in restoring the functionality?

@jeremystretch
Copy link
Member

Now tracking this as bug #18435.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
@jeremystretch jeremystretch removed the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants