#203 make sure cascade DELETE is applied #307
Open
+169
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #283
FK constraints weren't getting setup correctly as we use managed=False in the creation of the CO. Unfortunately this means we have to have direct SQL to create these. A side effect of this was showing some test issues with the cache so also put in extra cache clearing code that should hopefully fix up the multi-worker cache issues as well.
Now get standard deletion dialog showing related object that will be deleted.
Need migration to setup FK constraints for any existing models with FK, then code in models.py to check if any newly added fields should have FK constraints added.