Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Improve Mensa dish allergene parsing #350

Open
M4GNV5 opened this issue Oct 27, 2023 · 0 comments
Open

Fix/Improve Mensa dish allergene parsing #350

M4GNV5 opened this issue Oct 27, 2023 · 0 comments
Labels
API API related bug Something isn't working hackathon Will be solved during the next neuland.app Hackathon

Comments

@M4GNV5
Copy link
Member

M4GNV5 commented Oct 27, 2023

Describe the bug
Currently some allergene descriptions are parsed incorrectly and/or non-allergene declarations are parsed as allergenes.

To Reproduce
Compare https://www.max-manager.de/daten-extern/sw-erlangen-nuernberg/xml/mensa-ingolstadt.xml to https://dev.neuland.app/de/food/

Currently e.g.:
Gemüsesuppe ( So) mit Brötchen (Wz) turns into Gemüsesuppe ) mit Brötchen and the So allergene is even dropped / not included in our app

Expected behavior
Only known allergenes should be parsed, none should be dropped. Non-known (which probably never occurs, except in false positives) can remain in the name

Screenshots
image

Additional context

@M4GNV5 M4GNV5 added bug Something isn't working hackathon Will be solved during the next neuland.app Hackathon labels Oct 27, 2023
giselaortt added a commit to giselaortt/neuland.app that referenced this issue Oct 30, 2023
@Robert27 Robert27 linked a pull request Oct 30, 2023 that will close this issue
@Robert27 Robert27 added the API API related label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related bug Something isn't working hackathon Will be solved during the next neuland.app Hackathon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants