Skip to content

Commit 79d0a01

Browse files
more cleanup
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
1 parent 4006aef commit 79d0a01

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

vllm/engine/arg_utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -687,8 +687,6 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
687687
"--microbatch-schedule",
688688
dest="microbatch_schedule",
689689
**parallel_kwargs["microbatch_schedule"])
690-
parallel_group.add_argument("--enable-async-comms",
691-
**parallel_kwargs["enable_async_comms"])
692690
parallel_group.add_argument("--enable-eplb",
693691
**parallel_kwargs["enable_eplb"])
694692
parallel_group.add_argument("--eplb-config",

vllm/v1/worker/ubatching.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ def _cpu_yield(self, check_context: bool = True):
153153
# It is critical for correctness that only one thread is running
154154
# at a time. These asserts just make sure that this is the only
155155
# thread running before waking the other one up and going to sleep
156-
print(f"CPU yield {self.id} {type(forward_context._forward_context)} {type(self.forward_context)}")
157156
assert (
158157
not check_context or
159158
forward_context._forward_context is self.forward_context)
@@ -172,11 +171,6 @@ def switch_to_comm_sync(self):
172171
self.update_stream(self.comm_stream)
173172
self._wait_comm_done()
174173

175-
def switch_to_compute_sync(self):
176-
self._signal_comm_done()
177-
self.update_stream(self.compute_stream)
178-
self._wait_compute_done()
179-
180174
def maybe_run_recv_hook(self):
181175
if self.recv_hook is not None:
182176
self.recv_hook()
@@ -291,7 +285,6 @@ def make_ubatch_contexts(
291285
comm_stream: torch.cuda.Stream,
292286
forward_contexts: list[ForwardContext],
293287
ready_barrier: threading.Barrier,
294-
device: Optional[torch.device] = None,
295288
schedule: Schedule = Schedule.MLP_OVERLAP,
296289
delayed_start: bool = False,
297290
) -> list[UBatchContext]:

0 commit comments

Comments
 (0)