Skip to content

create getter for value options of a column (categorical or continuous) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
Tracked by #305
jarmoza opened this issue Dec 14, 2022 · 5 comments
Closed
3 tasks done
Tracked by #305
Assignees
Labels
annotation page refactor Simplifying or restructuring existing code or documentation.
Milestone

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Dec 14, 2022

Implement a getter that provides options for categorical column or transform heuristic options for a continuous values column.

Other requirements:

  • depending components have been checked and are calling this mutation correctly
  • have unit tests to check functionality
  • needed store state variables exist already or have been created if not
@jarmoza jarmoza added annotation page feature:addition refactor Simplifying or restructuring existing code or documentation. labels Dec 14, 2022
@jarmoza jarmoza moved this to Inbox in Neurobagel Dec 14, 2022
@surchs surchs added this to the v0.1.0 milestone Jan 10, 2023
@surchs surchs moved this from Inbox to Ready in Neurobagel Feb 1, 2023
@surchs
Copy link
Contributor

surchs commented Feb 1, 2023

Note: on the miro board, this getter is supposed to be called getOptions - this will likely need some refacvtoring of the affected components that are currently calling it under a different name

@jarmoza
Copy link
Contributor Author

jarmoza commented Feb 7, 2023

@surchs Is this our current list of transform heuristics for continuous values?

["float", "bounded", "euro", "range", "int", "string", "isoyear"]

This is taken from the component test for annot-continuous-values and the old convertAge in annot-age-values

@surchs
Copy link
Contributor

surchs commented Feb 7, 2023

Yes @jarmoza, that's what we have been calling them. That said: these were the names of the regex capture groups, if you think of more descriptive names, feel free to use (and document) those instead!

@jarmoza jarmoza moved this from Ready to Doing in Neurobagel Feb 8, 2023
@jarmoza jarmoza self-assigned this Feb 8, 2023
@jarmoza jarmoza moved this from Doing to Review in Neurobagel Feb 8, 2023
@jarmoza jarmoza moved this from Review to Blocked in Neurobagel Feb 15, 2023
@surchs
Copy link
Contributor

surchs commented Feb 16, 2023

@jarmoza is this Blocked or Fixed? Looks like #352 took care of it?

@jarmoza
Copy link
Contributor Author

jarmoza commented Feb 16, 2023

[Edit]

This had been marked as blocked pending discussion of the transform heuristics for the refactor - which we did.

Yes, this in fact is complete! @surchs , though I believe you meant #353. I forgot that I had completed the getter for the transform heuristics/continuous values as well in addition to the now separate getter for categorical data.

Closed by #353

@jarmoza jarmoza moved this from Blocked to Next in Neurobagel Feb 16, 2023
@jarmoza jarmoza closed this as completed Feb 16, 2023
@github-project-automation github-project-automation bot moved this from Next to Done in Neurobagel Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page refactor Simplifying or restructuring existing code or documentation.
Projects
Archived in project
Development

No branches or pull requests

2 participants