-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-robust default value for NB_API_QUERY_URL
in Compose recipes
#21
Comments
API_QUERY_URL
in federation recipeAPI_QUERY_URL
in Compose recipes
API_QUERY_URL
in Compose recipesNB_API_QUERY_URL
in Compose recipes
Starting the spec here: @neurobagel/dev between these two options:
I prefer the Once we get to #30, we could make this even more visible by putting the |
I think the |
🚀 Issue was released in |
As (re-)discovered in neurobagel/planning#111 (comment), when the query tool is part of a deployment that is meant to be accessed from other machines, the URL used for the API that it talks to has to be provided as it would appear to an external user on their own machine.
The query tool essentially always behaves as if the user has downloaded it and then run it on their own machine. So,
NB_API_QUERY_URL
must be set to a URL that makes sense from outside the machine hosting the API, such as the public IP of the host, or the subdomain for the API if NGINX is set up on the machine.One exception is if a user tries deploying our API stack on their local machine (and then tries the query tool from the same machine), in which case
NB_API_QUERY_URL
would need to belocalhost
(also because their laptop would not have a unique public IP). This should be documented clearly in a note to the user.Meanwhile, we should update the default in the
.env
file to a clearly toy/must-be-changed URL, e.g.:12.34.56.78
XX.XX.XX.XX
See also Bump tailwindcss from 3.4.12 to 3.4.14 query-tool#343
The text was updated successfully, but these errors were encountered: