fixes 218 merge in nl middleware helpful classes #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@senthurayyappan I broke the doc generation when I renamed the time folder to timing. Should I manually go change things in the docs folder or is there a command I should run to update them? |
merge Feature/documentation into profiler feature branch
|
@senthurayyappan this should be good to go. It would be nice to merge soon-ish so that Ellie and Varun can use the profiler in their pip installed version. |
|
@senthurayyappan all requested changes have been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged in the NLMiddleware profiler class that Gray wrote. I modified the unit tests to fit our setup and tested each mode.