`data` ambiguity on WSL platform

[faaiqgwaqar]

Error shows up while running the build command specifically on WSL. Not reproducable on other platform. Example message below:

BankWithHtree.cpp:413:27: error: reference to ‘data’ is ambiguous
  413 |         if (memoryType == data) {
      |                           ^~~~
/usr/include/c++/13/bits/range_access.h:346:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(initializer_list<_Tp>)’
  346 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:336:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  336 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:325:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  325 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:314:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  314 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
typedef.h:91:9: note:                 ‘MemoryType data’
   91 |         data,
      |         ^~~~
BankWithHtree.cpp:440:27: error: reference to ‘data’ is ambiguous
  440 |         if (memoryType == data) {               /* Data array */
      |                           ^~~~
/usr/include/c++/13/bits/range_access.h:346:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(initializer_list<_Tp>)’
  346 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:336:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  336 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:325:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  325 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:314:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  314 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
typedef.h:91:9: note:                 ‘MemoryType data’
   91 |         data,
      |         ^~~~
BankWithHtree.cpp: In member function ‘virtual void BankWithHtree::CalculateArea()’:
BankWithHtree.cpp:534:35: error: reference to ‘data’ is ambiguous
  534 |                 if (memoryType == data)
      |                                   ^~~~
/usr/include/c++/13/bits/range_access.h:346:5: note: candidates are: ‘template<class _Tp> constexpr const _Tp* std::data(initializer_list<_Tp>)’
  346 |     data(initializer_list<_Tp> __il) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:336:5: note:                 ‘template<class _Tp, long unsigned int _Nm> constexpr _Tp* std::data(_Tp (&)[_Nm])’
  336 |     data(_Tp (&__array)[_Nm]) noexcept
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:325:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(const _Container&)’
  325 |     data(const _Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
/usr/include/c++/13/bits/range_access.h:314:5: note:                 ‘template<class _Container> constexpr decltype (__cont.data()) std::data(_Container&)’
  314 |     data(_Container& __cont) noexcept(noexcept(__cont.data()))
      |     ^~~~
typedef.h:91:9: note:                 ‘MemoryType data’
   91 |         data,
      |         ^~~~
make: *** [Makefile:46: obj/BankWithHtree.o] Error 1
make: Leaving directory '/home/wodzrose/ns_cache/NS-Cache/src'```

[mingyeen99]

This error may happen depending on the compiler. This happens because unscoped enum members (data, tag, CAM) in the typedef.h are injected into the global namespace and can easily conflict with other identifiers such as std::data, macros, or symbols defined in system headers.
Please add "MemoryType::" ahead of each "data" variable. e.g "if (memoryType == MemoryType::data)"

[thebiertrix]

Can report the same issue, compiling with gcc in Ubuntu 22.04. Based on the fix suggested by mingyeen99, this workaround seems to solve the issue (i.e., using sed in Linux to replace "data" with "MemoryType::data" in all affected source code files):

git clone https://github.com/neurosim/NS-Cache.git 
cd NS-Cache 
sed -i -e 's/= data/= MemoryType::data/g' src/BankWithHtree.cpp 
sed -i -e 's/= data/= MemoryType::data/g' src/BankWithoutHtree.cpp 
sed -i -e 's/= data/= MemoryType::data/g' src/Result.cpp 
sed -i -e 's/= data/= MemoryType::data/g' src/SubArray.cpp 
sed -i -e 's/ data)/ MemoryType::data)/g' src/main.cpp 
make -C src/

Not a very clean solution, though. Would it be possible to directly fix this in the source code?