Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of cfg message from Field component #683

Open
emil14 opened this issue Jun 23, 2024 · 1 comment
Open

Remove usage of cfg message from Field component #683

emil14 opened this issue Jun 23, 2024 · 1 comment

Comments

@emil14
Copy link
Collaborator

emil14 commented Jun 23, 2024

It's possible to have normal inport like path that takes list<string>

What if user pass incorrect path? Should Field have err outport? No, it should panic. User should not use field in the first place. We need to add it to its description.

Problems

Runtime overhead

This is simplicity vs performance kind of tradeoff

  1. We need to allocate a message container which is a little bit bigger than native go slice
  2. We need to use network transmission machinery to make it work
@emil14
Copy link
Collaborator Author

emil14 commented Jun 23, 2024

I would like to add that runtime overhead of const is itself a problem regardless this specific case. See #681 for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant