Automatic env file resolution is in reverse order of precedence

[neverendingqs]

The README says

The env resolution pattern follows the one used by Rail's dotenv and create-react-app

But the code says

serverless-dotenv-plugin/index.js

Lines 64 to 72 in 6fc076c

	const dotenvFiles = [
	`.env.${env}.local`,
	`.env.${env}`,
	// Don't include `.env.local` for `test` environment
	// since normally you expect tests to produce the same
	// results for everyone
	env !== 'test' && `.env.local`,
	`.env`,
	]

and

serverless-dotenv-plugin/index.js

Lines 84 to 91 in 6fc076c

	const envVarsArray = envFileNames.map((fileName) => {
	const parsed = dotenv.config({ path: fileName })
	return this.variableExpansion
	? dotenvExpand(parsed).parsed
	: parsed.parsed
	})
	return envVarsArray.reduce((acc, curr) => ({ ...acc, ...curr }), {})

That last .reduce() call means we're actually resolving the files in reverse order of precedence, since env vars in lower priority files are overwriting the ones in higher priority files.

The fix is potentially a breaking change, and so requires a major version bump.

[danilofuchs]

When I implemented this, I used the create-react-app code as a sample. I now see this reduce may be causing issues.

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/env.js

[feeh27]

Is that why .env.local takes precedence over .env?

[danilofuchs]

Is that why .env.local takes precedence over .env?

.local should always have higher priority then their non-local equivalents. This is by design to allow a single dev to override a shared env

[feeh27]

Is that why .env.local takes precedence over .env?

.local should always have higher priority then their non-local equivalents. This is by design to allow a single dev to override a shared env

I use this plugin in my local environment and when I deploy to the environments, however .env.local is replacing the values of my .env file that is generated at run time in the deploy pipeline, the correct one wouldn't be .env take priority over .env.local?

[danilofuchs]

@feeh27 .env.local is intended to override .env. This is by design, not a bug.

You should not commit .env.local to your git repo. If you are running the deployment on an CI, it should not have access to .env.local at all.

If you are running the deployment locally, I suggest you use .env.development and .env.development.local when developing and then .env or .env.production when deploying. You can manage which file is read by using the --stage argument for serverless

[feeh27]

I understood, really the way the library works and the projects I work on understand the .env.local and .env differently.

I have already managed to adjust this in my pipelines deleting the .env.local.

Thank you for your attention.

[henrypenny]

I'm still seeing .env values override .env..local. In my case .env.test.local.