From 7ed646c2a5585d8f106a344b908568ce47d6ffeb Mon Sep 17 00:00:00 2001 From: Shiela Sabellita Date: Thu, 1 Aug 2024 17:51:51 +0800 Subject: [PATCH 1/2] fix(timeline_links): dont create if contact link and ref is not the same --- frappe/core/doctype/communication/communication.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/communication/communication.py b/frappe/core/doctype/communication/communication.py index b12eb832052f..71bf956e8f0a 100644 --- a/frappe/core/doctype/communication/communication.py +++ b/frappe/core/doctype/communication/communication.py @@ -355,7 +355,7 @@ def set_timeline_links(self): self.add_link("Contact", contact_name) # link contact's dynamic links to communication - add_contact_links_to_communication(self, contact_name) + # add_contact_links_to_communication(self, contact_name) # commented out as the dynamic links: Customer/Supplier should not be linked to communication only on Contact timeline def deduplicate_timeline_links(self): if self.timeline_links: @@ -592,3 +592,4 @@ def set_avg_response_time(parent, communication): if response_times: avg_response_time = sum(response_times) / len(response_times) parent.db_set("avg_response_time", avg_response_time) + From de5d072ab4517390a1b4f5bd5f54d53eda647a3b Mon Sep 17 00:00:00 2001 From: Shiela Sabellita Date: Thu, 1 Aug 2024 21:14:08 +0800 Subject: [PATCH 2/2] fix: comment adding of commonucation link to dynamic link contacts --- frappe/core/doctype/communication/communication.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/core/doctype/communication/communication.py b/frappe/core/doctype/communication/communication.py index 71bf956e8f0a..9fb992381bad 100644 --- a/frappe/core/doctype/communication/communication.py +++ b/frappe/core/doctype/communication/communication.py @@ -355,7 +355,7 @@ def set_timeline_links(self): self.add_link("Contact", contact_name) # link contact's dynamic links to communication - # add_contact_links_to_communication(self, contact_name) # commented out as the dynamic links: Customer/Supplier should not be linked to communication only on Contact timeline + # add_contact_links_to_communication(self, contact_name) # Commented out as the dynamic links: Customer/Supplier should not be linked to communication only on Contact timeline def deduplicate_timeline_links(self): if self.timeline_links: