Pino does not work with ESM loader in v11

[y-a-v-a]

Description

In a NextJS 12.3.4 application we have a custom server along with Pino and NewRelic.

{
  "@newrelic/next": "0.5.2",
  "@types/newrelic": "9.14.0",
  "newrelic": "11.1.0",
  "pino": "8.15.7",
  "pino-pretty": "10.2.3",
  "next": "12.3.4"
}

When I start up Next with the following command, the application starts throwing errors immediately, but nothing to stdout or stderr.

NEW_RELIC_APP_NAME="DEV Storefront" NEW_RELIC_NO_CONFIG_FILE=true NEW_RELIC_ENABLED=true NEW_RELIC_LICENSE_KEY=123abc NODE_OPTIONS="--experimental-loader newrelic/esm-loader.mjs -r @newrelic/next --inspect" node ./server.js

From the inspector panel I do see the following:

From one.newrelic.com we see continuous errors reported

                                                      at ThreadStream.write (/usr/src/app/storefront/node_modules/thread-stream/index.js:232:19)
                                                                  at Pino.write (/usr/src/app/storefront/node_modules/pino/lib/proto.js:215:10)
                                                          at Pino.LOG [as error] (/usr/src/app/storefront/node_modules/pino/lib/tools.js:62:21)
                                                                              at process.<anonymous> (/usr/src/app/storefront/server.js:101:12)
                                                                                                          /at process.emit (node:events:526:35)
                    at process.wrappedEmit [as emit] (/usr/src/app/storefront/node_modules/newrelic/lib/instrumentation/core/globals.js:54:23)
                                                                                at process.<anonymous> (node:internal/process/execution:149:25)
at process.wrappedFatalException [as _fatalException] (/usr/src/app/storefront/node_modules/newrelic/lib/instrumentation/core/globals.js:33:23)

Expected Behavior

No errors are reported, output is sent to stdout.

Troubleshooting or NR Diag results

Steps to Reproduce

Your Environment

NextJS v12.3.4 runs in a Docker container, versions of deps as mentioned above.
Also reproducible on Mac OS 13.5.2
NodeJS 18.17.1

All works as expected when using NewRelic v10.x.x (up until its latest version).

Additional context

Similar report found here: https://forum.newrelic.com/s/hubtopic/aAX8W000000PHYsWAO/newrelic-does-not-show-logs-for-nextjs-app?t=1696848988884

Upgrading @newrelic/next doesn't make a difference. Dropping pino-pretty in favor of using pino/file doesn't make a difference either.

[workato-integration]

https://issues.newrelic.com/browse/NR-168634

[bizob2828]

Hi @y-a-v-a sorry for your troubles. Can you provide a more concrete reproduction case?

[y-a-v-a]

Example repo here:
https://github.com/y-a-v-a/newrelic-pino
branch main errors
branch no-pino works like a charm ;-)

Cheers,
Vincent

[bizob2828]

Hi @y-a-v-a this is a duplicate of #1777. It's a bug in a 3rd party package we use to instrument ESM(import-in-the-middle). I'll close this as a duplicate. For now, since you're using Node 18 I recommend staying on 10.x of newrelic until this issue can be fixed.

I also noticed you're using the ESM loader and a standalone server. If you rely on next CLI you could get rid of loader by doing NODE_OPTIONS='-r @newrelic/next' next start

[y-a-v-a]

Hi @bizob2828, thanks for the feedback. Let's await the fix in the 3rd party package then.
It's a pity though that in all communication my manager reads, it is stressed to keep up by installing the latest versions of all NewRelic packages, and that it's considered a vulnerability when lagging behind... After digging into code for 1.5 days I now need to convince people to ignore these warnings and that we should settle with an older version.

#1777 is almost worth a mention in the README, or at least in the release notes, imho. We'll keep an eye on this repo!
Cheers, Vincent