Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reminding adding custom server URL when using Valine comments and *international version of* LeanCloud #114

Closed
3 tasks done
No5972 opened this issue Sep 24, 2020 · 5 comments
Labels
📖 Docs Improvements or additions to documentation Solved 🔌 3rd Party Plugin
Milestone

Comments

@No5972
Copy link
Contributor

No5972 commented Sep 24, 2020

Please follow this Issue template to provide relevant information, such as source code repository, website URL and screenshots, which will help us investigate.
请按照此 Issue 模版提供相关信息,例如源码仓库、网站链接和屏幕截图,这将有助于我们进行调查。

Issue Checklist

  • I am using the latest version of NexT.
  • I have already read the relevant documents of Hexo and NexT.
  • I have already searched for current issues, which does not help me.

Expected behavior

Comments should be displayed and articles should be comments when using Valine and international version of LeanCloud.

Actual behavior

It says "no comments yet". This is the LeanCloud issue and it just has happened since yesterday (Sep 23).

After adding a custom server URL (URL can be found in the backend management of LeanCloud), the valine turns good.

  • Links to demo site with this issue:
  • Links to repository or source code of the blog:
  • Screenshots:

Steps to reproduce the behavior

  1. Create an app in the international version of LeanCloud
  2. Add "Comment" class in the Objects of LeanStorage
  3. Specify AppID and AppKey of Valine in _config.yml of NexT
  4. Deploy. But Valine is unavailable.
  5. Go to Settings - App Keys, find the new domain in the "Request domain" in "Domain wihtelist" of LeanCloud backend management, and Specify serverURLs of Valine in _config.yml of NexT with the new domain.
  6. Deploy again and the Valine is available.

Other Information

This is the fault that has just happened since yesterday. The previous domain us.avoscloud.com seems to be deprecated but the possibility of recovery is not ruled out. Therefore please consider reminding adding custom server URL when using Valine comments and international version of LeanCloud.

@No5972 No5972 added the Feature Request New feature or request label Sep 24, 2020
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@No5972 No5972 changed the title Consider reminding adding customer server URL when using Valine comments and *international version of* LeanCloud Consider reminding adding custom server URL when using Valine comments and *international version of* LeanCloud Sep 24, 2020
@stevenjoezhang stevenjoezhang added the 📖 Docs Improvements or additions to documentation label Sep 24, 2020
@sli1989
Copy link

sli1989 commented Sep 25, 2020

xCss/Valine#340


adding https://

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Sep 25, 2020

Valine is no longer open source since version 1.4.0. Therefore we cannot solve this problem. Please wait for the author of Valine to update.

Relevant code (in Valine version 1.3.10):
https://github.com/xCss/Valine/blob/87da8204db50194c338f6929166f80f41ca87222/src/index.js#L189-L203
See also xCss/Valine#340 (comment)

const api_server = app_id.slice(-9) !== '-MdYXbMMI' ? server_url : `https://${app_id.slice(0, 8).toLowerCase()}.api.lncldglobal.com`;

@stevenjoezhang stevenjoezhang added 🔌 3rd Party Plugin and removed Feature Request New feature or request labels Sep 26, 2020
@stevenjoezhang
Copy link
Member

Docs updated 9919fb5

@stevenjoezhang stevenjoezhang added this to the 8.0.1 milestone Sep 26, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 Docs Improvements or additions to documentation Solved 🔌 3rd Party Plugin
Projects
None yet
Development

No branches or pull requests

3 participants