Skip to content

Smart picker issues when opened from Text #8213

@julien-nc

Description

@julien-nc

We get TypeError: link.sub.notify is not a function in some occasions when opening the smart picker in Text.

Image

The stack points to https://github.com/nextcloud/text_templates/blob/feat/vue3/src/views/TemplateCustomPickerElement.vue#L139 which is just an affectation to a data prop. It seems like the upper Vue context of the Text app is complaining about what the Vue 3 picker component does.

Steps to reproduce the issue with the text_templates app

  • Context: Use the master branch of server and text. Use the feat/vue3 branch of text_templates. Build the text_templates assets with npm
  • Go to the personal settings, in the Additional settings section, add at least one text template
  • Open a text file with Text
  • Type /text and select the Text templates
  • Check the browser console

@ShGKme It reminds me of something we discussed a while back but I can't remember the details. I think it was related with build options and nested Vue instances. At the time, the nc/vue lib was still in Vue 2 and Text as well.
Now text_templates is using @nextcloud/vue 9 but Text is still using Vue 2 and @nextcloud/vue 8.

cc @janepie

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions