From cfceb5409d9f66364196eb69b2fb6be3c9a9a502 Mon Sep 17 00:00:00 2001 From: skjnldsv Date: Fri, 30 May 2025 16:03:08 +0200 Subject: [PATCH 1/2] fix(cypress): do not fail on artifcts handling failures Signed-off-by: skjnldsv --- workflow-templates/cypress.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/workflow-templates/cypress.yml b/workflow-templates/cypress.yml index b3e00184..60be8828 100644 --- a/workflow-templates/cypress.yml +++ b/workflow-templates/cypress.yml @@ -140,17 +140,20 @@ jobs: - name: Upload snapshots uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + continue-on-error: true if: always() with: name: snapshots_${{ matrix.containers }} path: cypress/snapshots - name: Extract NC logs + continue-on-error: true if: failure() && matrix.containers != 'component' run: docker logs nextcloud-cypress-tests-${{ env.APP_NAME }} > nextcloud.log - name: Upload NC logs uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + continue-on-error: true if: failure() && matrix.containers != 'component' with: name: nc_logs_${{ matrix.containers }} From 9194fa2056ed6aefb3ba6a852ae993e7becc9179 Mon Sep 17 00:00:00 2001 From: skjnldsv Date: Fri, 30 May 2025 16:22:41 +0200 Subject: [PATCH 2/2] fix: permissions for `dorny/paths-filter` action Signed-off-by: skjnldsv --- workflow-templates/lint-eslint.yml | 5 ++--- workflow-templates/lint-typescript.yml | 5 ++--- workflow-templates/node-test.yml | 5 ++--- workflow-templates/node.yml | 5 ++--- workflow-templates/phpunit-mariadb.yml | 5 ++--- workflow-templates/phpunit-mysql.yml | 5 ++--- workflow-templates/phpunit-oci.yml | 5 ++--- workflow-templates/phpunit-pgsql.yml | 5 ++--- workflow-templates/phpunit-sqlite.yml | 5 ++--- 9 files changed, 18 insertions(+), 27 deletions(-) diff --git a/workflow-templates/lint-eslint.yml b/workflow-templates/lint-eslint.yml index 1b1d5328..82682e31 100644 --- a/workflow-templates/lint-eslint.yml +++ b/workflow-templates/lint-eslint.yml @@ -20,9 +20,8 @@ concurrency: jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/lint-typescript.yml b/workflow-templates/lint-typescript.yml index d42341f1..3161511e 100644 --- a/workflow-templates/lint-typescript.yml +++ b/workflow-templates/lint-typescript.yml @@ -26,9 +26,8 @@ concurrency: jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/node-test.yml b/workflow-templates/node-test.yml index 1b221a5b..e279c474 100644 --- a/workflow-templates/node-test.yml +++ b/workflow-templates/node-test.yml @@ -26,9 +26,8 @@ concurrency: jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/node.yml b/workflow-templates/node.yml index d1f18a1c..349c02ea 100644 --- a/workflow-templates/node.yml +++ b/workflow-templates/node.yml @@ -20,9 +20,8 @@ concurrency: jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/phpunit-mariadb.yml b/workflow-templates/phpunit-mariadb.yml index 3eef2fa3..36b9fdf6 100644 --- a/workflow-templates/phpunit-mariadb.yml +++ b/workflow-templates/phpunit-mariadb.yml @@ -35,9 +35,8 @@ jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/phpunit-mysql.yml b/workflow-templates/phpunit-mysql.yml index 9e4f1f88..08e8d602 100644 --- a/workflow-templates/phpunit-mysql.yml +++ b/workflow-templates/phpunit-mysql.yml @@ -36,9 +36,8 @@ jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}} diff --git a/workflow-templates/phpunit-oci.yml b/workflow-templates/phpunit-oci.yml index 5c0f8489..cfd5a226 100644 --- a/workflow-templates/phpunit-oci.yml +++ b/workflow-templates/phpunit-oci.yml @@ -35,9 +35,8 @@ jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src }} diff --git a/workflow-templates/phpunit-pgsql.yml b/workflow-templates/phpunit-pgsql.yml index 8de195d2..bcb0f7fe 100644 --- a/workflow-templates/phpunit-pgsql.yml +++ b/workflow-templates/phpunit-pgsql.yml @@ -35,9 +35,8 @@ jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src }} diff --git a/workflow-templates/phpunit-sqlite.yml b/workflow-templates/phpunit-sqlite.yml index 9ddb9d21..eeef2d74 100644 --- a/workflow-templates/phpunit-sqlite.yml +++ b/workflow-templates/phpunit-sqlite.yml @@ -35,9 +35,8 @@ jobs: changes: runs-on: ubuntu-latest-low - permissions: - contents: read - pull-requests: read + # Required for dorny/paths-filter + permissions: read-all outputs: src: ${{ steps.changes.outputs.src}}