Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis fails #586

Closed
artonge opened this issue May 10, 2021 · 2 comments
Closed

Static analysis fails #586

artonge opened this issue May 10, 2021 · 2 comments
Labels
1. to develop bug

Comments

@artonge
Copy link
Collaborator

artonge commented May 10, 2021

Steps to reproduce

Static analysis fails: https://github.com/nextcloud/activity/runs/2546830151?check_suite_focus=true

@ChristophWurst @nickvergessen, an idea why ?

Expected behaviour

Should not fails.

Actual behaviour

It fails 😉
@nickvergessen
Copy link
Member

The problem is ShareNotFound extends OC\HintException which is not public api.
There is nextcloud/server#26681 to fix it. Until then I guess you have to add it here or something:
https://github.com/nextcloud/activity/blob/master/psalm.xml#L16

@artonge artonge closed this as completed May 11, 2021
@nickvergessen nickvergessen reopened this May 12, 2021
@joshtrichards
Copy link
Member

Fixed long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickvergessen @joshtrichards @artonge