fix(deps): Upgrade @nextcloud/vue to fix focus-trap compatibility #4920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade @nextcloud/vue from ^8.27.0 to ^8.34.0 to resolve focus-trap library version mismatch with the guests app. The mismatch caused "_setPausedState is not a function" error when opening the guest invite dialog from the Teams member picker. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
nfebe
force-pushed
the
fix/focus-trap-version-mismatch
branch
from
31b818d to
ff6515c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade @nextcloud/vue from ^8.27.0 to ^8.34.0 to resolve focus-trap library version mismatch with the guests app. The mismatch caused "_setPausedState is not a function" error when opening the guest invite dialog from the Teams member picker.
Without this the "Invite guest" modal does not work over the "Add team members" modal.