Merge pull request #1915 from nextcloud/refactor/ignores

Author: provokateurin

packages/neon/neon_notes/lib/src/blocs/note.dart

@@ -53,8 +53,7 @@ class _NotesNoteBloc extends InteractiveBloc implements NotesNoteBloc {
     etag = note.etag;
   }
 
-  // ignore: avoid_void_async
-  void wrapNoteAction(Future<DynamiteResponse<notes.Note, dynamic>> Function(String etag) call) async {
+  Future<void> wrapNoteAction(Future<DynamiteResponse<notes.Note, dynamic>> Function(String etag) call) async {
     await updateQueue.add(() async {
       try {
         final response = await call(etag);
@@ -99,8 +98,8 @@ class _NotesNoteBloc extends InteractiveBloc implements NotesNoteBloc {
   Future<void> refresh() async {}
 
   @override
-  void updateCategory(String category) {
-    wrapNoteAction(
+  Future<void> updateCategory(String category) async {
+    await wrapNoteAction(
       (etag) async => account.client.notes.updateNote(
         id: id,
         category: category,
@@ -110,8 +109,8 @@ class _NotesNoteBloc extends InteractiveBloc implements NotesNoteBloc {
   }
 
   @override
-  void updateContent(String content) {
-    wrapNoteAction(
+  Future<void> updateContent(String content) async {
+    await wrapNoteAction(
       (etag) async => account.client.notes.updateNote(
         id: id,
         content: content,
@@ -121,8 +120,8 @@ class _NotesNoteBloc extends InteractiveBloc implements NotesNoteBloc {
   }
 
   @override
-  void updateTitle(String title) {
-    wrapNoteAction(
+  Future<void> updateTitle(String title) async {
+    await wrapNoteAction(
       (etag) async => account.client.notes.updateNote(
         id: id,
         title: title,

packages/neon/neon_talk/lib/src/dialogs/create_room.dart

@@ -149,7 +149,6 @@ class _TalkCreateRoomDialogState extends State<TalkCreateRoomDialog> {
       onFieldSubmitted: (_) {
         submit();
       },
-      // ignore: avoid_types_on_closure_parameters
       resultBuilder: buildResult,
       onSelected: (result) {
         setState(() {

packages/neon/neon_talk/test/create_room_dialog_test.dart

@@ -1,4 +1,3 @@
-// ignore_for_file: prefer_asserts_with_message
 import 'dart:convert';
 
 import 'package:built_collection/built_collection.dart';

packages/neon_framework/lib/src/app.dart

@@ -51,7 +51,6 @@ class NeonApp extends StatefulWidget {
   State<NeonApp> createState() => _NeonAppState();
 }
 
-// ignore: prefer_mixin
 class _NeonAppState extends State<NeonApp> with WidgetsBindingObserver, WindowListener {
   final _appRegex = RegExp(r'^app_([a-z]+)$', multiLine: true);
   final _navigatorKey = GlobalKey<NavigatorState>();

packages/neon_framework/lib/src/storage/sqlite_persistence.dart

@@ -1,5 +1,3 @@
-// ignore_for_file: cascade_invocations
-
 import 'dart:async';
 import 'dart:convert';
 
@@ -159,8 +157,9 @@ WHERE prefix = ?
         fromSystem[key] = _decode(value) as Object;
       }
 
-      cache.clear();
-      cache.addAll(fromSystem);
+      cache
+        ..clear()
+        ..addAll(fromSystem);
     } on DatabaseException catch (error) {
       _log.warning(
         'Error reloading the SQLite persistence.',

packages/neon_framework/lib/src/theme/color_scheme.dart

@@ -10,6 +10,18 @@ class NeonColorScheme {
     this.primary = NcColors.primary,
   });
 
+  /// Linearly interpolate between two [NeonColorScheme]s.
+  ///
+  /// {@macro dart.ui.shadow.lerp}
+  factory NeonColorScheme.lerp(NeonColorScheme a, NeonColorScheme b, double t) {
+    if (identical(a, b)) {
+      return a;
+    }
+    return NeonColorScheme(
+      primary: Color.lerp(a.primary, b.primary, t)!,
+    );
+  }
+
   /// Primary color used throughout the app.
   ///
   /// See [ColorScheme.primary]
@@ -28,19 +40,6 @@ class NeonColorScheme {
   /// The data from the closest [NeonColorScheme] instance given the build context.
   static NeonColorScheme of(BuildContext context) => Theme.of(context).extension<NeonTheme>()!.colorScheme;
 
-  /// Linearly interpolate between two [NeonColorScheme]s.
-  ///
-  /// {@macro dart.ui.shadow.lerp}
-  // ignore: prefer_constructors_over_static_methods
-  static NeonColorScheme lerp(NeonColorScheme a, NeonColorScheme b, double t) {
-    if (identical(a, b)) {
-      return a;
-    }
-    return NeonColorScheme(
-      primary: Color.lerp(a.primary, b.primary, t)!,
-    );
-  }
-
   @override
   int get hashCode => Object.hashAll([
         primary,

packages/neon_framework/lib/src/theme/dialog.dart

@@ -18,6 +18,19 @@ class NeonDialogTheme {
     this.padding = const EdgeInsets.all(24),
   });
 
+  /// Linearly interpolate between two [NeonDialogTheme]s.
+  ///
+  /// {@macro dart.ui.shadow.lerp}
+  factory NeonDialogTheme.lerp(NeonDialogTheme a, NeonDialogTheme b, double t) {
+    if (identical(a, b)) {
+      return a;
+    }
+    return NeonDialogTheme(
+      constraints: BoxConstraints.lerp(a.constraints, b.constraints, t)!,
+      padding: EdgeInsets.lerp(a.padding, b.padding, t)!,
+    );
+  }
+
   /// Used to configure the [BoxConstraints] for the [NeonDialog] widget.
   ///
   /// This value should also be used on [Dialog.fullscreen] and other similar pages.
@@ -44,20 +57,6 @@ class NeonDialogTheme {
   /// The data from the closest [NeonDialogTheme] instance given the build context.
   static NeonDialogTheme of(BuildContext context) => Theme.of(context).extension<NeonTheme>()!.dialogTheme;
 
-  /// Linearly interpolate between two [NeonDialogTheme]s.
-  ///
-  /// {@macro dart.ui.shadow.lerp}
-  // ignore: prefer_constructors_over_static_methods
-  static NeonDialogTheme lerp(NeonDialogTheme a, NeonDialogTheme b, double t) {
-    if (identical(a, b)) {
-      return a;
-    }
-    return NeonDialogTheme(
-      constraints: BoxConstraints.lerp(a.constraints, b.constraints, t)!,
-      padding: EdgeInsets.lerp(a.padding, b.padding, t)!,
-    );
-  }
-
   @override
   int get hashCode => Object.hashAll([
         constraints,

packages/neon_framework/test/option_test.dart

@@ -1,4 +1,4 @@
-// ignore_for_file: discarded_futures, inference_failure_on_instance_creation
+// ignore_for_file: inference_failure_on_instance_creation
 
 import 'package:flutter/foundation.dart';
 import 'package:flutter_test/flutter_test.dart';
@@ -37,7 +37,9 @@ void main() {
     late SelectOption<SelectValues> option;
 
     setUp(() {
+      // ignore: discarded_futures
       when(() => storage.setString(key.value, any())).thenAnswer((_) async => true);
+      // ignore: discarded_futures
       when(() => storage.remove(key.value)).thenAnswer((_) async => true);
 
       option = SelectOption<SelectValues>(
@@ -97,6 +99,7 @@ void main() {
         ..value = SelectValues.third;
 
       verify(callback.call).called(1);
+      // ignore: discarded_futures
       verify(() => storage.setString(key.value, 'SelectValues.third')).called(1);
       expect(option.value, SelectValues.third, reason: 'Should update the value.');
 
@@ -166,6 +169,7 @@ void main() {
       option.reset();
 
       verify(callback.call).called(1);
+      // ignore: discarded_futures
       verify(() => storage.remove(key.value)).called(1);
       expect(option.value, option.defaultValue, reason: 'Should reset the value.');
     });
@@ -216,7 +220,9 @@ void main() {
     late ToggleOption option;
 
     setUp(() {
+      // ignore: discarded_futures
       when(() => storage.setBool(key.value, any())).thenAnswer((_) async => true);
+      // ignore: discarded_futures
       when(() => storage.remove(key.value)).thenAnswer((_) async => true);
 
       option = ToggleOption(
@@ -273,6 +279,7 @@ void main() {
         ..value = false;
 
       verify(callback.call).called(1);
+      // ignore: discarded_futures
       verify(() => storage.setBool(key.value, false)).called(1);
       expect(option.value, false, reason: 'Should update the value.');
 
@@ -307,14 +314,14 @@ void main() {
       option.reset();
 
       verify(callback.call).called(1);
+      // ignore: discarded_futures
       verify(() => storage.remove(key.value)).called(1);
       expect(option.value, option.defaultValue, reason: 'Should reset the value.');
     });
 
     test('Deserialize', () {
       expect(option.value, true);
 
-      // ignore: cascade_invocations
       option.load(false);
 
       expect(option.value, false);

packages/neon_framework/test/persistence_test.dart

@@ -1,5 +1,4 @@
-// ignore_for_file: unnecessary_lambdas, inference_failure_on_instance_creation, strict_raw_type
-// ignore_for_file: inference_failure_on_collection_literal
+// ignore_for_file: inference_failure_on_instance_creation, strict_raw_type, inference_failure_on_collection_literal
 
 import 'package:built_collection/built_collection.dart';
 import 'package:cookie_store/cookie_store.dart';