Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Stacks conditional #801

Closed
Leptopoda opened this issue Sep 18, 2023 · 0 comments · Fixed by #863
Closed

Make Stacks conditional #801

Leptopoda opened this issue Sep 18, 2023 · 0 comments · Fixed by #863
Assignees
@provokateurin
Labels
refactoring Something that needs to be refactored

Comments

@Leptopoda
Copy link
Member

Leptopoda commented Sep 18, 2023 •
edited
Loading

In quite a few places we have a stack with one child and conditionally add an overlay.
It would be more oerfoemant by directly returning the first child if no other is going to be added.

sorta related to #696
@Leptopoda Leptopoda added the refactoring Something that needs to be refactored label Sep 18, 2023
@provokateurin provokateurin mentioned this issue Sep 28, 2023
Merged
@provokateurin provokateurin self-assigned this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@provokateurin provokateurin

Labels
refactoring Something that needs to be refactored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(neon): Use Stacks conditionally nextcloud/neon
2 participants
@Leptopoda @provokateurin