From ca13aa132eb7a2d095614c943229c19791c3a9f7 Mon Sep 17 00:00:00 2001 From: provokateurin Date: Sat, 7 Sep 2024 17:59:16 +0200 Subject: [PATCH 1/2] fix(news_app): Apply size constraint in NewsFeedIcon Signed-off-by: provokateurin --- .../news_app/lib/src/widgets/feed_icon.dart | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart b/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart index 180d6683270..592db58c56e 100644 --- a/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart +++ b/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart @@ -21,16 +21,19 @@ class NewsFeedIcon extends StatelessWidget { Widget build(BuildContext context) { final faviconLink = feed.faviconLink; - return faviconLink != null && faviconLink.isNotEmpty - ? NeonUriImage( - uri: Uri.parse(faviconLink), - size: Size.square(size), - account: NeonProvider.of(context), - ) - : Icon( - Icons.rss_feed, - size: size, - color: Theme.of(context).colorScheme.primary, - ); + return SizedBox.square( + dimension: size, + child: faviconLink != null && faviconLink.isNotEmpty + ? NeonUriImage( + uri: Uri.parse(faviconLink), + size: Size.square(size), + account: NeonProvider.of(context), + ) + : Icon( + Icons.rss_feed, + size: size, + color: Theme.of(context).colorScheme.primary, + ), + ); } } From 0a04fcf1b14d1ebbb0190af7781a6276bda8011c Mon Sep 17 00:00:00 2001 From: provokateurin Date: Sat, 7 Sep 2024 17:59:49 +0200 Subject: [PATCH 2/2] chore(news_app): Remove unused borderRadius parameter from NewsFeedIcon Signed-off-by: provokateurin --- .../packages/news_app/lib/src/widgets/articles_view.dart | 1 - .../packages/news_app/lib/src/widgets/feed_icon.dart | 2 -- 2 files changed, 3 deletions(-) diff --git a/packages/neon_framework/packages/news_app/lib/src/widgets/articles_view.dart b/packages/neon_framework/packages/news_app/lib/src/widgets/articles_view.dart index 80e53b0df63..2bf1b763143 100644 --- a/packages/neon_framework/packages/news_app/lib/src/widgets/articles_view.dart +++ b/packages/neon_framework/packages/news_app/lib/src/widgets/articles_view.dart @@ -187,7 +187,6 @@ class _NewsArticlesViewState extends State { child: NewsFeedIcon( feed: feed, size: smallIconSize, - borderRadius: const BorderRadius.all(Radius.circular(2)), ), ), RelativeTime( diff --git a/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart b/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart index 592db58c56e..33099783a1c 100644 --- a/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart +++ b/packages/neon_framework/packages/news_app/lib/src/widgets/feed_icon.dart @@ -9,13 +9,11 @@ class NewsFeedIcon extends StatelessWidget { const NewsFeedIcon({ required this.feed, this.size = largeIconSize, - this.borderRadius, super.key, }); final news.Feed feed; final double size; - final BorderRadius? borderRadius; @override Widget build(BuildContext context) {