Subscribe button container has a scrollbar

[lgabardos]

Hi,
In version 25,
I know it's not something highly important but the div in which the "Subscribe" button is has a scrollbar without any reason.

Looking at the "Contact" app, it seems that the "Add" button is inside the "search" slot
So I'm wondering if, in "src/components/Sidebar.vue" we can put the "new-feed-button" inside the search slot too

<template #search>
    <NcAppNavigationNew :text="t('news', 'Subscribe')"
	button-id="new-feed-button"
	button-class="icon-add"
	:icon="''"
	@click="showShowAddFeed()">
	<template #icon>
		<PlusIcon />
	</template>
    </NcAppNavigationNew>
</template>

I would really love to create a PR but I don't know how can I test this change?
Is there any documentation somewhere in order to build manually the app and deploy it locally?

Thanks,
Laurent

[wofferl]

Thanks for the info. The search slot is used when you want an in-app search (see NcAppNavigation)
I will have a look later, I think we simply need to disable the overflow for NcAppNavigation here.

You can find docs about developing here:
CONTRIBUTING.md
docker/README.md

[lgabardos]

Yeah a css overflow could do the job.

I really found the "contributing.md" after I paste the message, sorry about that...
I'll try to run it, if I can test easily, I'll create a PR if you prefer

[lgabardos]

I found the "slot" way is more elegant and it's working nicely.
The CSS way, if I'm correct, will need to create a "global" CSS to point to the correct element, so something like

#news-app #app-navigation-vue .app-navigation__body {
    overflow: hidden;
}

If (it's a big "if" I know that) in the future, we will want to use the default slot, we'll be screwed...

If it makes sense ?
Also, having the "Subscribe" button in the header seems to follow the "Contact app" pattern

[lgabardos]

@wofferl I'm trying to create a PR with the change in order you to have a look. But to push a branch I need to have a write access on the repo.
Where should I obtain such a permission?

[Grotax]

You simply create a fork of the repository GitHub should even do that automatically when you use the Webinterface to edit a file.