fix(files): use isDownloadable for isSyncable

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>

[skip ci]

Author: skjnldsv

apps/files/src/utils/permissions.ts

@@ -36,33 +36,21 @@ export function isDownloadable(node: Node): boolean {
 	return true
 }
 
-
 /**
  * Check permissions on the node if it can be synced/open locally
  *
  * @param node The node to check
  * @return True if syncable, false otherwise
  */
 export function isSyncable(node: Node): boolean {
-	if ((node.permissions & Permission.UPDATE) === 0) {
+	if (!node.isDavResource) {
 		return false
 	}
 
-	// check hide-download property of shares
-	if (node.attributes['hide-download'] === true
-		|| node.attributes['hide-download'] === 'true'
-	) {
+	if ((node.permissions & Permission.UPDATE) === 0) {
 		return false
 	}
 
-	// If the mount type is a share, ensure it got download permissions.
-	if (node.attributes['share-attributes']) {
-		const shareAttributes = JSON.parse(node.attributes['share-attributes'] || '[]') as Array<ShareAttribute>
-		const downloadAttribute = shareAttributes.find(({ scope, key }: ShareAttribute) => scope === 'permissions' && key === 'download')
-		if (downloadAttribute !== undefined) {
-			return downloadAttribute.value === true
-		}
-	}
-
-	return true
-}
+	// Syncable has the same permissions as downloadable for now
+	return isDownloadable(node)
+}