Skip to content

Commit 53db3d9

Browse files
committed
fix(files): ensure details doesn't trigger view
When going into "Shared with you" and into a shared folder, clicking "Details" on the three-dot-menu triggers the file to open. This ensures that it doesn't trigger it. Signed-off-by: Kent Delante <kent.delante@proton.me>
1 parent 39e3250 commit 53db3d9

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

apps/files/src/actions/sidebarAction.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ describe('Open sidebar action exec tests', () => {
130130
expect(goToRouteMock).toBeCalledWith(
131131
null,
132132
{ view: view.id, fileid: '1' },
133-
{ dir: '/', opendetails: 'true' },
133+
{ dir: '/', opendetails: 'true', openfile: 'false' },
134134
true,
135135
)
136136
})
@@ -159,7 +159,7 @@ describe('Open sidebar action exec tests', () => {
159159
expect(goToRouteMock).toBeCalledWith(
160160
null,
161161
{ view: view.id, fileid: '1' },
162-
{ dir: '/', opendetails: 'true' },
162+
{ dir: '/', opendetails: 'true', openfile: 'false' },
163163
true,
164164
)
165165
})

apps/files/src/actions/sidebarAction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export const action = new FileAction({
5959
window.OCP?.Files?.Router?.goToRoute(
6060
null,
6161
{ view: view.id, fileid: String(node.fileid) },
62-
{ ...window.OCP.Files.Router.query, dir, opendetails: 'true' },
62+
{ ...window.OCP.Files.Router.query, dir, opendetails: 'true', openfile: 'false' },
6363
true,
6464
)
6565

dist/files-init.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-init.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_sharing-init.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_sharing-init.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)