fix(cache): filter out invalid entries in OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsById

susnux · susnux · commit bb58e475952b · 2026-02-12T14:53:55.000+01:00
Signed-off-by: Ferdinand Thiessen &lt;opensource@fthiessen.de&gt;
diff --git a/lib/private/Files/Cache/Wrapper/CacheWrapper.php b/lib/private/Files/Cache/Wrapper/CacheWrapper.php
@@ -88,14 +88,14 @@ public function getFolderContents($folder) {
 	}
 
 	/**
-	 * get the metadata of all files stored in $folder
+	 * Get the metadata of all files stored in given folder
 	 *
 	 * @param int $fileId the file id of the folder
-	 * @return array
+	 * @return ICacheEntry[]
 	 */
 	public function getFolderContentsById($fileId) {
 		$results = $this->getCache()->getFolderContentsById($fileId);
-		return array_map([$this, 'formatCacheEntry'], $results);
+		return array_filter(array_map($this->formatCacheEntry(...), $results));
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -88,14 +88,14 @@ public function getFolderContents($folder) {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`/**`
`91`		`- * get the metadata of all files stored in $folder`
	`91`	`+ * Get the metadata of all files stored in given folder`
`92`	`92`	`*`
`93`	`93`	`* @param int $fileId the file id of the folder`
`94`		`- * @return array`
	`94`	`+ * @return ICacheEntry[]`
`95`	`95`	`*/`
`96`	`96`	`public function getFolderContentsById($fileId) {`
`97`	`97`	`$results = $this->getCache()->getFolderContentsById($fileId);`
`98`		`- return array_map([$this, 'formatCacheEntry'], $results);`
	`98`	`+ return array_filter(array_map($this->formatCacheEntry(...), $results));`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`/**`