Use Correct Foreground Colors for Texts in Dark and Light Modes

[alperozturk96]

Problem

Recently modified files are highlighted well in dark mode, but files modified some time ago use a grey color that doesn't provide good contrast.

Solution

Corresponding foreground color must be used for icons and texts.

[tobiasKaminsky]

Android: nextcloud/android#13309
Android notes: nextcloud/notes-android#2300

[susnux]

This is done on purpose:
Older files get slightly less intense colors to reflect their age.
This color is based on the modification time and range from maxcontrast to main text.

CC @nextcloud/designers if we should remove this feature.

[susnux]

Android: nextcloud/android#13309
Android notes: nextcloud/notes-android#2300

No this are different issues, this one is about a special files feature to adjust the color based on how old the file is.

In general we have two forground colors main-text and maxcontrast, in the past we used to make icons maxconstrast but from design reviews we changed icons to main text color, so probably for the linked issue just also make the icon main text color?

[nimishavijay]

This is done on purpose: Older files get slightly less intense colors to reflect their age. This color is based on the modification time and range from maxcontrast to main text.

I would vote for removing this in the interest of maintaining consistency of colors.

We can start off with removing the range of colors and sticking to --color-main-text for recent files and --color-text-maxcontrast for older files as the result of the color mix is often too subtle to notice anyway.

[skjnldsv]

I would vote for removing this in the interest of maintaining consistency of colors.

We do have the same for file sizes. The larger the file, the stronger the size color will be. This is an old feature that many uses. ⚠️

[marcoambrosini]

I think that everything should be of the same color, same as the file name. I don't think the feature is helpful because it's not easy to understand what these color difference indicate.

[jancborchardt]

We do have the same for file sizes. The larger the file, the stronger the size color will be. This is an old feature that many uses. ⚠️

Exactly, as @susnux and @skjnldsv said this was intentionally added a long time ago and is a nice differentiator for us compared to other solutions as well.

• It helps distinguish newer (aka more relevant) files even if the list is sorted alphabetically
• It also directly highlights larger (using more space if you need to clean up for example)

So no, we should not remove this. (FYI @nimishavijay @marcoambrosini) And as said the contrast is fine since the lowest we go is color-text-maxcontrast.

We also do a similar thing with the file extensions in the file list, because they are not as important as the file name itself. It helps to focus.