diff --git a/css/modal.css b/css/modal.css index bc95b535f..fab6eea44 100644 --- a/css/modal.css +++ b/css/modal.css @@ -7,7 +7,7 @@ } .modal__content { - padding: 20px; + padding: 0 0 20px 20px; } .modal__content h2 { diff --git a/cypress/e2e/column-selection-multi.cy.js b/cypress/e2e/column-selection-multi.cy.js index be1c62fe3..02de7e04d 100644 --- a/cypress/e2e/column-selection-multi.cy.js +++ b/cypress/e2e/column-selection-multi.cy.js @@ -30,10 +30,11 @@ describe('Test column ' + columnTitle, () => { // check if default value is set on row creation cy.get('button').contains('Create row').click() - cy.get('.modal__content h2').contains('Create row').should('be.visible') + cy.get('.modal-container__content h2').contains('Create row').should('be.visible') cy.get('.modal__content .title').contains(columnTitle).should('be.visible') cy.get('.modal__content span[title="first option"]').should('be.visible') cy.get('.modal__content span[title="second option"]').should('be.visible') + cy.get('.modal__content .title').click() // focus out of the multiselect cy.get('button').contains('Save').click() cy.get('.custom-table table tr td div').contains('first option').should('be.visible') cy.get('.custom-table table tr td div').contains('second option').should('be.visible') @@ -44,6 +45,7 @@ describe('Test column ' + columnTitle, () => { cy.get('.vs--multiple .vs__selected button').first().click() cy.get('.modal__content .slot input').first().click() cy.get('ul.vs__dropdown-menu li span[title="👋 third option"]').click() + cy.get('.modal__content .title').click() // focus out of the multiselect cy.get('button').contains('Save').click() cy.get('.custom-table table tr td div').contains('third option').should('be.visible') @@ -58,6 +60,7 @@ describe('Test column ' + columnTitle, () => { cy.get('.NcTable tr td button').first().click() cy.get('.modal__content .slot input').first().click() cy.get('ul.vs__dropdown-menu li span[title="first option"]').click() + cy.get('.modal__content .title').click() // focus out of the multiselect cy.get('button').contains('Save').click() cy.get('.custom-table table tr td div').contains('first option').should('be.visible') cy.get('.custom-table table tr td div').contains('third option').should('be.visible') @@ -76,7 +79,7 @@ describe('Test column ' + columnTitle, () => { // check if default value is set on row creation cy.get('button').contains('Create row').click() - cy.get('.modal__content h2').contains('Create row').should('be.visible') + cy.get('.modal-container__content h2').contains('Create row').should('be.visible') cy.get('button').contains('Save').click() cy.get('.custom-table table tr td div').should('exist') cy.get('.NcTable tr td button').should('exist') diff --git a/cypress/e2e/column-selection.cy.js b/cypress/e2e/column-selection.cy.js index 96277b325..a8edd1c78 100644 --- a/cypress/e2e/column-selection.cy.js +++ b/cypress/e2e/column-selection.cy.js @@ -30,7 +30,7 @@ describe('Test column ' + columnTitle, () => { // check if default value is set on row creation cy.get('button').contains('Create row').click() - cy.get('.modal__content h2').contains('Create row').should('be.visible') + cy.get('.modal-container__content h2').contains('Create row').should('be.visible') cy.get('.modal__content .title').contains(columnTitle).should('be.visible') cy.get('.modal__content .title').click() cy.get('.vs__dropdown-toggle .vs__selected span[title="second option"]').should('exist') @@ -71,7 +71,7 @@ describe('Test column ' + columnTitle, () => { // check if default value is set on row creation cy.get('button').contains('Create row').click() - cy.get('.modal__content h2').contains('Create row').should('be.visible') + cy.get('.modal-container__content h2').contains('Create row').should('be.visible') cy.get('button').contains('Save').click() cy.get('.custom-table table tr td div').should('exist') cy.get('.NcTable tr td button').should('exist') diff --git a/cypress/e2e/column-text-line.cy.js b/cypress/e2e/column-text-line.cy.js index d1d1fc4ea..e6cc52b49 100644 --- a/cypress/e2e/column-text-line.cy.js +++ b/cypress/e2e/column-text-line.cy.js @@ -30,7 +30,7 @@ describe('Test column text line', () => { // check if default value is set on row creation cy.get('button').contains('Create row').click() - cy.get('.modal__content h2').contains('Create row').should('be.visible') + cy.get('.modal-container__content h2').contains('Create row').should('be.visible') cy.get('.modal__content .title').contains('text line').should('be.visible') cy.get('.modal__content input').first().should('be.visible') cy.get('.modal__content input').first().clear().type('hello world') diff --git a/cypress/support/e2e.js b/cypress/support/e2e.js index a3cb3f742..26a4dd3b9 100644 --- a/cypress/support/e2e.js +++ b/cypress/support/e2e.js @@ -20,5 +20,6 @@ import './commands.js' Cypress.on('uncaught:exception', (err) => { - return !err.message.includes('ResizeObserver loop limit exceeded') + return !err.message.includes('ResizeObserver loop limit exceeded') && + !err.message.includes('ResizeObserver loop completed with undelivered notifications') }) \ No newline at end of file diff --git a/src/modules/modals/CreateColumn.vue b/src/modules/modals/CreateColumn.vue index b7f9db2c7..2c5a46c13 100644 --- a/src/modules/modals/CreateColumn.vue +++ b/src/modules/modals/CreateColumn.vue @@ -3,13 +3,12 @@ - SPDX-License-Identifier: AGPL-3.0-or-later -->