From c5dbd2f98f0f6f8fd9961ad5492af2a37a596d5a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 27 Jun 2024 08:06:33 +0200
Subject: [PATCH 1/3] fix: Add aria-label to pagination
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/shared/components/ncTable/sections/CustomTable.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/shared/components/ncTable/sections/CustomTable.vue b/src/shared/components/ncTable/sections/CustomTable.vue
index e1c59b9ab..2c4cab219 100644
--- a/src/shared/components/ncTable/sections/CustomTable.vue
+++ b/src/shared/components/ncTable/sections/CustomTable.vue
@@ -38,12 +38,12 @@
 		</table>
 		<div v-if="totalPages > 1" class="pagination-footer" :class="{'large-width': !appNavCollapsed || isMobile}">
 			<div class="pagination-items">
-				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber <= 1" @click="pageNumber = 1">
+				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber <= 1" :aria-label="t('tables', 'Go to first page')" @click="pageNumber = 1">
 					<template #icon>
 						<PageFirstIcon :size="20" />
 					</template>
 				</NcButton>
-				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber <= 1" @click="pageNumber--">
+				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber <= 1" :aria-label="t('tables', 'Go to previous page')" @click="pageNumber--">
 					<template #icon>
 						<ChevronLeftIcon :size="20" />
 					</template>
@@ -57,12 +57,12 @@
 						</template>
 					</NcSelect>
 				</div>
-				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber >= totalPages" @click="pageNumber++">
+				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber >= totalPages" :aria-label="t('tables', 'Go to next page')" @click="pageNumber++">
 					<template #icon>
 						<ChevronRightIcon :size="20" />
 					</template>
 				</NcButton>
-				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber >= totalPages" @click="pageNumber = totalPages">
+				<NcButton type="tertiary" :disabled="totalPages === 1 || pageNumber >= totalPages" :aria-label="t('tables', 'Go to last page')" @click="pageNumber = totalPages">
 					<template #icon>
 						<PageLastIcon :size="20" />
 					</template>

From 030b57d996bde5ad89f81df8a22ad3d61a21952e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 27 Jun 2024 08:06:18 +0200
Subject: [PATCH 2/3] fix: Fix missing actions for empty default slot
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 cypress/e2e/tables-favorite.cy.js                      |  6 +++---
 .../navigation/partials/NavigationTableItem.vue        | 10 ++++++----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/cypress/e2e/tables-favorite.cy.js b/cypress/e2e/tables-favorite.cy.js
index ac35b0391..73d4d295a 100644
--- a/cypress/e2e/tables-favorite.cy.js
+++ b/cypress/e2e/tables-favorite.cy.js
@@ -50,7 +50,7 @@ describe('Favorite tables/views', () => {
 
     cy.get('[data-cy="navigationViewItem"]').first().as('testView')
 
-    cy.get('@testView').parent().parent().should('contain.text', 'Tutorial')
+    cy.get('@testView').parent().parent().parent().should('contain.text', 'Tutorial')
     cy.get('@testView').find('[aria-haspopup="menu"]').click({ force: true })
 
     cy.intercept({ method: 'POST', url: '**/ocs/v2.php/apps/tables/api/2/favorites/*/*' }).as('favoriteViewReq')
@@ -70,14 +70,14 @@ describe('Favorite tables/views', () => {
     cy.contains('Remove from favorites').click({ force: true })
     cy.wait('@unfavoriteViewReq').its('response.statusCode').should('equal', 200)
 
-    cy.get('@testView').parent().parent().should('contain.text', 'Tutorial')
+    cy.get('@testView').parent().parent().parent().should('contain.text', 'Tutorial')
   })
 
   it('can (un)favorite views with favorited parent tables', () => {
     cy.get('[data-cy="navigationViewItem"]').first().as('testView')
     cy.get('[data-cy="navigationTableItem"]').first().as('tutorialTable')
 
-    cy.get('@testView').parent().parent().should('contain.text', 'Tutorial')
+    cy.get('@testView').parent().parent().parent().should('contain.text', 'Tutorial')
     cy.get('@testView').find('[aria-haspopup="menu"]').click({ force: true })
     cy.contains('Add to favorites').click({ force: true })
 
diff --git a/src/modules/navigation/partials/NavigationTableItem.vue b/src/modules/navigation/partials/NavigationTableItem.vue
index 9daeed369..b6ee1f6af 100644
--- a/src/modules/navigation/partials/NavigationTableItem.vue
+++ b/src/modules/navigation/partials/NavigationTableItem.vue
@@ -136,10 +136,12 @@
 				{{ t('tables', 'Delete table') }}
 			</NcActionButton>
 		</template>
-		<NavigationViewItem v-for="view in getViews"
-			:key="'view'+view.id"
-			:view="view"
-			:show-share-sender="false" />
+		<div>
+			<NavigationViewItem v-for="view in getViews"
+				:key="'view'+view.id"
+				:view="view"
+				:show-share-sender="false" />
+		</div>
 	</NcAppNavigationItem>
 </template>
 

From 6e6cba4ba19d6354d5135accabb726e166149170 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Mon, 17 Jun 2024 07:50:40 +0200
Subject: [PATCH 3/3] fix: Proper evaluation order when building errors strings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/shared/utils/displayError.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/utils/displayError.js b/src/shared/utils/displayError.js
index 9943278ab..96aa691c8 100644
--- a/src/shared/utils/displayError.js
+++ b/src/shared/utils/displayError.js
@@ -37,7 +37,7 @@ function statusMessage(status) {
  * @param {string} msg as message to toast out
  */
 function displaySimpleError(e = null, msg = '') {
-	console.error('Error occurred: ' + msg ?? '', e?.message)
+	console.error('Error occurred: ' + (msg ?? ''), e?.message)
 	showError(msg)
 }