Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Contexts): add Contexts to navigation when applicable #904

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 5, 2024

solves #863

needs #903 (soft)

wants nextcloud/server#44178

  • generate correct link
  • does not appear yet for the owner even if there is a share where display is enabled for all
  • move logic from application to db query (see TODO remark in code)

Screenshot made with frontend from #844. On the content area in the UI we don't render the material icons yet, but the icon is in the nav bar. The icon over the mouse pointer is material design, while the two icons on the very right have fallback icons (default app icon).

Screenshot_20240313_161237

@blizzz blizzz added the 2. developing Work in progress label Mar 5, 2024
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise looks straight forward

lib/AppInfo/Application.php Outdated Show resolved Hide resolved
lib/AppInfo/Application.php Outdated Show resolved Hide resolved
@blizzz blizzz force-pushed the enh/863/navigation branch 2 times, most recently from 47729eb to 2feda37 Compare March 7, 2024 21:30
@blizzz blizzz force-pushed the enh/noid/contexts-api branch 2 times, most recently from 1a4fcd2 to f45d956 Compare March 11, 2024 16:44
@blizzz blizzz force-pushed the enh/noid/contexts-api branch 3 times, most recently from 76d64d3 to dd896ac Compare March 12, 2024 17:41
@blizzz blizzz force-pushed the enh/863/navigation branch 2 times, most recently from a91c25b to 10c1c97 Compare March 12, 2024 18:06
Base automatically changed from enh/noid/contexts-api to feat/contexts March 12, 2024 19:18
@blizzz
Copy link
Member Author

blizzz commented Mar 13, 2024

@enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).

@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 13, 2024
@blizzz blizzz marked this pull request as ready for review March 13, 2024 15:18
@blizzz blizzz added the enhancement New feature or request label Mar 13, 2024
@juliushaertl
Copy link
Member

@enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).

I think this is tricky to do on the frontend. We may need a separate backend route to still render the TemplateResponse but then set the active entry on the navigation manager. We can then set an initial state that indicates that we're on an application page and to further adjustments on the frontend side like hiding the navigation by default. Something for a follow up I'd say.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Mar 14, 2024

@enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).

I think this is tricky to do on the frontend. We may need a separate backend route to still render the TemplateResponse but then set the active entry on the navigation manager. We can then set an initial state that indicates that we're on an application page and to further adjustments on the frontend side like hiding the navigation by default. Something for a follow up I'd say.

Ah, I was speculating that such an option exist for fronted, but of course… why would it. There was no similar case before. Follow up is fine +1

@juliushaertl juliushaertl merged commit 1b2d9b5 into feat/contexts Mar 14, 2024
46 checks passed
@juliushaertl juliushaertl deleted the enh/863/navigation branch March 14, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants