From 45d64e73bfa4beffb3768d1f01a6a98ee65d69e1 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 8 Jun 2023 18:27:59 +0200 Subject: [PATCH] finetune preferences for M3 - DRAFT Signed-off-by: Andy Scherzinger --- .../ConversationInfoActivity.kt | 7 + .../res/layout/activity_conversation_info.xml | 13 +- .../res/layout/item_guest_access_settings.xml | 123 +++++++++--------- .../res/layout/item_notification_settings.xml | 84 ++++++------ app/src/main/res/layout/item_webinar_info.xml | 108 +++++++-------- app/src/main/res/values/dimens.xml | 2 + 6 files changed, 177 insertions(+), 160 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt b/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt index 1d1240bb444..c5453931ea8 100644 --- a/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt +++ b/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt @@ -281,6 +281,13 @@ class ConversationInfoActivity : binding.notificationSettingsView.notificationSettingsCallNotifications ).forEach(viewThemeUtils.talk::ConversationInfoCardView) } + binding.run { + listOf( + binding.notificationSettingsView.notificationSettingsCategory, + binding.webinarInfoView.webinarSettingsCategory, + binding.guestAccessView.guestAccessSettingsCategory + ) + }.forEach(viewThemeUtils.platform::colorTextView) } private fun showSharedItems() { diff --git a/app/src/main/res/layout/activity_conversation_info.xml b/app/src/main/res/layout/activity_conversation_info.xml index 87ef63454c6..4fc4b4c1feb 100644 --- a/app/src/main/res/layout/activity_conversation_info.xml +++ b/app/src/main/res/layout/activity_conversation_info.xml @@ -86,7 +86,9 @@ + android:layout_height="match_parent" + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginEnd="@dimen/standard_margin"> @@ -124,9 +127,11 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_centerHorizontal="true" - android:layout_margin="@dimen/standard_half_margin" + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginBottom="@dimen/standard_half_margin" + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginEnd="@dimen/standard_margin" android:autoLink="web" - android:padding="@dimen/standard_half_padding" tools:text="Hello world!" /> @@ -223,7 +228,6 @@ android:textStyle="bold" android:padding="@dimen/standard_padding"/> - - diff --git a/app/src/main/res/layout/item_guest_access_settings.xml b/app/src/main/res/layout/item_guest_access_settings.xml index f70242833c8..aac1979b483 100644 --- a/app/src/main/res/layout/item_guest_access_settings.xml +++ b/app/src/main/res/layout/item_guest_access_settings.xml @@ -2,9 +2,9 @@ + android:layout_height="match_parent" + android:orientation="vertical"> + android:orientation="vertical"> + android:textStyle="bold" /> + android:layout_marginTop="@dimen/standard_quarter_margin"> + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginEnd="@dimen/standard_margin" + android:layout_marginBottom="@dimen/standard_half_margin" + android:orientation="horizontal"> + android:layout_weight="1" + android:orientation="vertical"> + android:textSize="@dimen/headline_text_size" /> + android:hint="@string/nc_guest_access_allow_summary" + android:textSize="@dimen/supporting_text_text_size" /> @@ -67,7 +69,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center_vertical" - /> + android:layout_marginStart="@dimen/standard_margin" /> @@ -75,16 +77,16 @@ + android:layout_height="wrap_content"> @@ -95,17 +97,16 @@ android:orientation="vertical"> + android:textSize="@dimen/headline_text_size" /> + android:hint="@string/nc_guest_access_password_summary" + android:textSize="@dimen/supporting_text_text_size" /> @@ -113,7 +114,8 @@ android:id="@+id/password_protection_switch" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_gravity="center_vertical" /> + android:layout_gravity="center_vertical" + android:layout_marginStart="@dimen/standard_margin" /> @@ -121,39 +123,39 @@ + android:layout_height="wrap_content"> - + + android:textSize="@dimen/headline_text_size" /> @@ -163,39 +165,39 @@ + android:layout_height="wrap_content"> - + + android:textSize="@dimen/headline_text_size" /> @@ -203,7 +205,6 @@ - diff --git a/app/src/main/res/layout/item_notification_settings.xml b/app/src/main/res/layout/item_notification_settings.xml index c215b833ab9..5b3309fe72f 100644 --- a/app/src/main/res/layout/item_notification_settings.xml +++ b/app/src/main/res/layout/item_notification_settings.xml @@ -1,9 +1,9 @@ + android:layout_height="wrap_content" + android:orientation="vertical"> + android:orientation="vertical"> + android:textStyle="bold" /> + android:layout_height="wrap_content"> + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginEnd="@dimen/standard_margin" + android:layout_marginBottom="@dimen/standard_half_margin" + android:orientation="horizontal"> + android:layout_weight="1" + android:orientation="vertical"> + android:textSize="@dimen/headline_text_size" /> + android:hint="@string/nc_important_conversation_desc" + android:textSize="@dimen/supporting_text_text_size" /> @@ -65,7 +67,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_gravity="center_vertical" - /> + android:layout_marginStart="@dimen/standard_margin" /> @@ -75,10 +77,12 @@ style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox.ExposedDropdownMenu" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginHorizontal="@dimen/standard_half_margin" + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginEnd="@dimen/standard_margin" + android:layout_marginBottom="@dimen/standard_half_margin" android:hint="@string/nc_plain_old_messages" - app:boxStrokeWidth="@dimen/zero" - > + app:boxStrokeWidth="1dp"> + android:text="" /> @@ -95,37 +99,35 @@ + android:layout_height="56dp"> + android:paddingTop="@dimen/standard_half_padding" + android:paddingBottom="@dimen/standard_half_padding" + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginEnd="@dimen/standard_margin"> - + + android:layout_marginStart="@dimen/standard_margin" + android:checked="true" /> - - diff --git a/app/src/main/res/layout/item_webinar_info.xml b/app/src/main/res/layout/item_webinar_info.xml index 810ed20c34c..5ba5785329c 100644 --- a/app/src/main/res/layout/item_webinar_info.xml +++ b/app/src/main/res/layout/item_webinar_info.xml @@ -1,9 +1,9 @@ + android:layout_height="match_parent" + android:orientation="vertical"> + android:orientation="vertical"> + android:textStyle="bold" /> + android:layout_height="wrap_content"> + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginEnd="@dimen/standard_margin" + android:orientation="horizontal"> - - + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginBottom="@dimen/standard_half_margin" + android:layout_weight="1" + android:orientation="horizontal"> + + + android:textSize="@dimen/headline_text_size" /> @@ -67,10 +69,11 @@ + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginEnd="1dp" + android:checked="true" /> @@ -78,45 +81,46 @@ + android:layout_height="wrap_content"> - - + android:layout_height="wrap_content" + android:layout_marginStart="@dimen/standard_margin" + android:layout_marginTop="@dimen/standard_half_margin" + android:layout_marginEnd="@dimen/standard_margin" + android:layout_marginBottom="@dimen/standard_half_margin" + android:gravity="center_vertical" + android:orientation="horizontal"> + + + android:layout_weight="1" + android:orientation="vertical"> + android:textSize="@dimen/headline_text_size" /> + android:textSize="@dimen/supporting_text_text_size" /> @@ -125,8 +129,6 @@ - - diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 149b0be4ba1..d5c617524e5 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -52,6 +52,8 @@ 24dp 16dp 16sp + 16sp + 14sp 56dp 24dp 32dp