From acd964869d5f52bdae8c50020cef2ce71b85146a Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Thu, 14 Nov 2024 12:27:22 +0100 Subject: [PATCH] add disposable however i was not able to see onDestroy being executed. anyway, disposables won't be necessary when coroutine is used. also: remove a useless outdated log line Signed-off-by: Marcel Hibbe --- app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt index 0161123c7f..8becfc6c82 100644 --- a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt +++ b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt @@ -2448,7 +2448,7 @@ class ChatActivity : currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here adapter = null - Log.d(TAG, "inConversation was set to false!") + disposables.dispose() } private fun joinRoomWithPassword() { @@ -2513,7 +2513,7 @@ class ChatActivity : ?.observeOn(AndroidSchedulers.mainThread()) ?.subscribe(object : Observer { override fun onSubscribe(d: Disposable) { - // unused atm + disposables.add(d) } override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) {