Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video call outgoing video preview cropped to screen resolution #2535

Open
ASerbinski opened this issue Oct 31, 2022 · 0 comments
Open

Video call outgoing video preview cropped to screen resolution #2535

ASerbinski opened this issue Oct 31, 2022 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working

Comments

@ASerbinski
Copy link
Contributor

Steps to reproduce

Initiate video call and observe aspect ratio of preview to be equal to screen ratio and potentially a different aspect ratio on the receiving side of the conversation.

This is most noticeable with extremely stretched aspect ratios such as the 19.5:9 ratio on Pixel 6/7 Pro since the video aspect ratio is 16:9.

Expected behaviour

The preview video aspect ratio should be an exact match to the actual video aspect ratio.

Actual behaviour

The preview video aspect ratio matches the screen aspect ratio.

Device brand and model

Pixel 6/7 Pro

Android version

13

Nextcloud Talk app version

15.0.1

Nextcloud server version

25

Talk version

15.0.0

Custom Signaling server configured

No response

Custom TURN server configured

No response

Custom STUN server configured

No response

Android logs

No response

Server log

No response

Additional information

The issue was caused by THIS commit; 892ffe8

Reverting it causes the preview aspect ratio to again match the video aspect ratio.

Granted, the difference doesn't appear to be particularly large in most cases, but when this commit (#2297) is merged allowing native sensor aspect ratio, the issue will become significant, since it won't be possible to preview what the camera actually captures.

@ASerbinski ASerbinski added bug Something isn't working 0. Needs triage 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) and removed 0. Needs triage labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant