Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new conversation #4064

Merged
merged 23 commits into from
Sep 5, 2024
Merged

Create new conversation #4064

merged 23 commits into from
Sep 5, 2024

Conversation

sowjanyakch
Copy link
Collaborator

@sowjanyakch sowjanyakch commented Aug 12, 2024 •
edited
Loading

This PR includes:

  • Creates a new conversation
    • Create a public conversation.
    • Set a password for public conversation.
    • Add Participants.
    • Edit Participants.
    • Make conversation available for registered users and guest app users.

User avatar selection and adding participants through search will be implemented in a different PR.

These will be implemented in a different PR.

partly resolve #3794
partly resolve #1463

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft August 12, 2024 07:22
@mahibi mahibi mentioned this pull request Sep 2, 2024
Closed
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Sep 3, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review September 3, 2024 09:41
@sowjanyakch sowjanyakch added this to the 20.1.0 milestone Sep 3, 2024
@mahibi
Copy link
Collaborator

mahibi commented Sep 3, 2024

offline-support-bug-fixes must be merged first (fix to open the conversations that did not exist in conversation list yet)

@mahibi mahibi mentioned this pull request Sep 3, 2024
Merged
5 tasks
@mahibi
Copy link
Collaborator

mahibi commented Sep 4, 2024

/backport to stable-20.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@sowjanyakch @mahibi
ConversationCreationActivity UI
cd01c80 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
ConversationCreationActivity - Refactoring
d32bc74 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add isAddParticipant flag
9f61793 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
don't create room on clicking contacts when creating a new conversation
b5f7556 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
MultiSelect contacts
e57c13e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add participants endpoint
0913b16 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
update ContactsViewModelTest - shareTypes
9ae0d52 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add participants
6a01309 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add participants list
6d0144d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Start ContactsActivity to edit participants
6b82d72 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Create public conversation
2959d8e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
sowjanyakch and others added 12 commits September 5, 2024 15:41
@sowjanyakch @mahibi
Created a public conversation
3db1f72 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Solved error unable to create call adapter for GenericOverall
dba56dd 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Refactor createRoom()
cb6fdf6 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Set password
1187b41 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
make conversation available for registered users and guest app users
5f3d73e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Properly select and deselect contact items
ff63bcd 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Work on warnings
5237832 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
Ktlint Format
ecb3d53 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi
only set password if not empty
8d1d446 
otherwise response will be 400

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix to align Participants header
8a59dd9 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
colorize status bar
5001fd0 
...for ConversationCreationActivity and ContactsActivityCompose

just a quick fix, this may not be the best solution!

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
change wording for visibility of new conversation
2fbe3db 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi merged commit 38c1b6b into master Sep 5, 2024
12 of 16 checks passed
@mahibi mahibi deleted the create_new_conversation branch September 5, 2024 13:50
@backportbot backportbot bot mentioned this pull request Sep 5, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4064-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

improve Contacts activity (group creation, federation invitations, ...) Improve/Align group creation
2 participants
@sowjanyakch @mahibi