Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Edit Time limit on Note to Self Messages #4122

Merged
merged 1 commit into from
Aug 29, 2024
Merged

No Edit Time limit on Note to Self Messages #4122

merged 1 commit into from
Aug 29, 2024

Conversation

sowjanyakch
Copy link
Collaborator

Resolves #4108

Allow editing of "Note to self" messages forever

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch
No Edit Time limit on Note to Self
2636979 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch sowjanyakch self-assigned this Aug 29, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Aug 29, 2024
@sowjanyakch sowjanyakch changed the title No Edit Time limit on Note to Self No Edit Time limit on Note to Self Messages Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8686
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4122-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004
Copy link
Contributor

/backport to stable-20.0

@rapterjet2004 rapterjet2004 merged commit 23eb15f into master Aug 29, 2024
21 checks passed
@rapterjet2004 rapterjet2004 deleted the edit_note_to_self branch August 29, 2024 12:14
@backportbot backportbot bot mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow editing of "Note to self" messages forever
3 participants
@sowjanyakch @rapterjet2004 @nickvergessen