Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publish to Windows Package Manager (winget) to CI jobs #928

Open
ShGKme opened this issue Nov 25, 2024 · 6 comments · May be fixed by #1002
Open

Add Publish to Windows Package Manager (winget) to CI jobs #928

ShGKme opened this issue Nov 25, 2024 · 6 comments · May be fixed by #1002

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Nov 25, 2024

Making it manually with wingetcreate is straightforward. But it should be automated.

@Refhi
Copy link

Refhi commented Dec 9, 2024

I guess it's normal as it's not automated yet, but winget is still on 1.0.0-rc2 where it should be v1.0.0

Thanks :)

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 16, 2024

I guess it's normal as it's not automated yet, but winget is still on 1.0.0-rc2 where it should be v1.0.0

Hmm... The PR has been merged on the release date. But winget still shows the old version...

microsoft/winget-pkgs#195980

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 16, 2024

Hmm x2, 1.0.0 has actually been successfully published.

Image

According to the docs, 1.0.0 should be bigger than 1.0.0-rc2, but it is not. It seems that part 0 is not bigger than 0-rc2...

@ETSPMeder
Copy link

See comparisons Table
The -rc causes Version B to have a string in the second Part where Version A does not
https://github.com/microsoft/winget-pkgs/blob/master/doc/Authoring.md#examples-of-version-comparisons

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 17, 2024

See comparisons Table
The -rc causes Version B to have a string in the second Part where Version A does not

See "Comparison Result" in the table. It says Version A which means 1.2 > 1.2-rc

Version A Version B Comparison Result Explanation
1.2 1.2-rc Version A The -rc causes Version B to have a string in the second Part where Version

@nickvergessen
Copy link
Member

nickvergessen commented Dec 17, 2024

Could try with a dot (after the word rc) next time. I remember a similar thing from the past i think version compare in php does it similarly, this is why we use v20.1.0-rc.3 and so on in talk.
Otherwise we just never publish rcs there again

@ShGKme ShGKme linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants