feat: remove blocking #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMelt
force-pushed
the
remove-blocking
branch
from
e2ddd9d
to
3c56d8c
Compare
TomMelt
force-pushed
the
remove-blocking
branch
from
3c56d8c
to
abbb29b
Compare
jwallwork23
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks @TomMelt, this tidies things up nicely. Just one minor comment on comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50
Blocking was added back in commit 3161a06 but it does not have a use case in the nextsimdg code. It adds unnecessary complexity to the
decomptool and so we have decided to remove it. For discussion see issue #50