refactor: ddns (#414)

* refactor ddns

* update webhook

Author: uubulb

cmd/dashboard/controller/controller.go

@@ -1,7 +1,6 @@
 package controller
 
 import (
-	"encoding/json"
 	"fmt"
 	"html/template"
 	"io/fs"
@@ -277,7 +276,7 @@ func natGateway(c *gin.Context) {
 	rpc.NezhaHandlerSingleton.CreateStream(streamId)
 	defer rpc.NezhaHandlerSingleton.CloseStream(streamId)
 
-	taskData, err := json.Marshal(model.TaskNAT{
+	taskData, err := utils.Json.Marshal(model.TaskNAT{
 		StreamID: streamId,
 		Host:     natConfig.Host,
 	})

cmd/dashboard/controller/oauth2.go

@@ -2,7 +2,6 @@ package controller
 
 import (
 	"context"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"net/http"
@@ -199,7 +198,7 @@ func (oa *oauth2controller) callback(c *gin.Context) {
 			if err == nil {
 				defer resp.Body.Close()
 				var cloudflareUserInfo *cloudflare.UserInfo
-				if err := json.NewDecoder(resp.Body).Decode(&cloudflareUserInfo); err == nil {
+				if err := utils.Json.NewDecoder(resp.Body).Decode(&cloudflareUserInfo); err == nil {
 					user = cloudflareUserInfo.MapToNezhaUser()
 				}
 			}

model/rule.go

@@ -1,6 +1,7 @@
 package model
 
 import (
+	"slices"
 	"strings"
 	"time"
 
@@ -44,19 +45,6 @@ func percentage(used, total uint64) float64 {
 	return float64(used) * 100 / float64(total)
 }
 
-func maxSliceValue(slice []float64) float64 {
-	if len(slice) != 0 {
-		max := slice[0]
-		for _, val := range slice {
-			if max < val {
-				max = val
-			}
-		}
-		return max
-	}
-	return 0
-}
-
 // Snapshot 未通过规则返回 struct{}{}, 通过返回 nil
 func (u *Rule) Snapshot(cycleTransferStats *CycleTransferStats, server *Server, db *gorm.DB) interface{} {
 	// 监控全部但是排除了此服务器
@@ -145,7 +133,7 @@ func (u *Rule) Snapshot(cycleTransferStats *CycleTransferStats, server *Server,
 					temp = append(temp, tempStat.Temperature)
 				}
 			}
-			src = maxSliceValue(temp)
+			src = slices.Max(temp)
 		}
 	}
 

pkg/ddns/cloudflare.go

@@ -2,169 +2,217 @@ package ddns
 
 import (
 	"bytes"
-	"encoding/json"
 	"fmt"
 	"io"
 	"log"
 	"net/http"
+	"net/url"
+
+	"github.com/naiba/nezha/pkg/utils"
 )
 
+const baseEndpoint = "https://api.cloudflare.com/client/v4/zones"
+
 type ProviderCloudflare struct {
-	Secret string
+	secret       string
+	zoneId       string
+	recordId     string
+	domainConfig *DomainConfig
+}
+
+type cfReq struct {
+	Name    string `json:"name"`
+	Type    string `json:"type"`
+	Content string `json:"content"`
+	TTL     uint32 `json:"ttl"`
+	Proxied bool   `json:"proxied"`
+}
+
+type cfResp struct {
+	Result []struct {
+		ID   string `json:"id"`
+		Name string `json:"name"`
+	} `json:"result"`
+}
+
+func NewProviderCloudflare(s string) *ProviderCloudflare {
+	return &ProviderCloudflare{
+		secret: s,
+	}
 }
 
-func (provider *ProviderCloudflare) UpdateDomain(domainConfig *DomainConfig) bool {
+func (provider *ProviderCloudflare) UpdateDomain(domainConfig *DomainConfig) error {
 	if domainConfig == nil {
-		return false
+		return fmt.Errorf("获取 DDNS 配置失败")
 	}
+	provider.domainConfig = domainConfig
 
-	zoneID, err := provider.getZoneID(domainConfig.FullDomain)
+	err := provider.getZoneID()
 	if err != nil {
-		log.Printf("无法获取 zone ID: %s\n", err)
-		return false
+		return fmt.Errorf("无法获取 zone ID: %s", err)
 	}
 
 	// 当IPv4和IPv6同时成功才算作成功
-	var resultV4 = true
-	var resultV6 = true
-	if domainConfig.EnableIPv4 {
-		if !provider.addDomainRecord(zoneID, domainConfig, true) {
-			resultV4 = false
+	if provider.domainConfig.EnableIPv4 {
+		if err = provider.addDomainRecord(true); err != nil {
+			return err
 		}
 	}
 
-	if domainConfig.EnableIpv6 {
-		if !provider.addDomainRecord(zoneID, domainConfig, false) {
-			resultV6 = false
+	if provider.domainConfig.EnableIpv6 {
+		if err = provider.addDomainRecord(false); err != nil {
+			return err
 		}
 	}
 
-	return resultV4 && resultV6
+	return nil
 }
 
-func (provider *ProviderCloudflare) addDomainRecord(zoneID string, domainConfig *DomainConfig, isIpv4 bool) bool {
-	record, err := provider.findDNSRecord(zoneID, domainConfig.FullDomain, isIpv4)
+func (provider *ProviderCloudflare) addDomainRecord(isIpv4 bool) error {
+	err := provider.findDNSRecord(isIpv4)
 	if err != nil {
-		log.Printf("查找 DNS 记录时出错: %s\n", err)
-		return false
+		return fmt.Errorf("查找 DNS 记录时出错: %s", err)
 	}
 
-	if record == nil {
+	if provider.recordId == "" {
 		// 添加 DNS 记录
-		return provider.createDNSRecord(zoneID, domainConfig, isIpv4)
+		return provider.createDNSRecord(isIpv4)
 	} else {
 		// 更新 DNS 记录
-		return provider.updateDNSRecord(zoneID, record["id"].(string), domainConfig, isIpv4)
+		return provider.updateDNSRecord(isIpv4)
 	}
 }
 
-func (provider *ProviderCloudflare) getZoneID(domain string) (string, error) {
-	_, realDomain := SplitDomain(domain)
-	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones?name=%s", realDomain)
-	body, err := provider.sendRequest("GET", url, nil)
+func (provider *ProviderCloudflare) getZoneID() error {
+	_, realDomain := splitDomain(provider.domainConfig.FullDomain)
+	zu, _ := url.Parse(baseEndpoint)
+
+	q := zu.Query()
+	q.Set("name", realDomain)
+	zu.RawQuery = q.Encode()
+
+	body, err := provider.sendRequest("GET", zu.String(), nil)
 	if err != nil {
-		return "", err
+		return err
 	}
 
-	var res map[string]interface{}
-	err = json.Unmarshal(body, &res)
+	res := &cfResp{}
+	err = utils.Json.Unmarshal(body, res)
 	if err != nil {
-		return "", err
+		return err
 	}
 
-	result := res["result"].([]interface{})
+	result := res.Result
 	if len(result) > 0 {
-		zoneID := result[0].(map[string]interface{})["id"].(string)
-		return zoneID, nil
+		provider.zoneId = result[0].ID
+		return nil
 	}
 
-	return "", fmt.Errorf("找不到 Zone ID")
+	return fmt.Errorf("找不到 Zone ID")
 }
 
-func (provider *ProviderCloudflare) findDNSRecord(zoneID string, domain string, isIPv4 bool) (map[string]interface{}, error) {
-	var ipType = "A"
-	if !isIPv4 {
+func (provider *ProviderCloudflare) findDNSRecord(isIPv4 bool) error {
+	var ipType string
+	if isIPv4 {
+		ipType = "A"
+	} else {
 		ipType = "AAAA"
 	}
-	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records?type=%s&name=%s", zoneID, ipType, domain)
-	body, err := provider.sendRequest("GET", url, nil)
+
+	de, _ := url.JoinPath(baseEndpoint, provider.zoneId, "dns_records")
+	du, _ := url.Parse(de)
+
+	q := du.Query()
+	q.Set("name", provider.domainConfig.FullDomain)
+	q.Set("type", ipType)
+	du.RawQuery = q.Encode()
+
+	body, err := provider.sendRequest("GET", du.String(), nil)
 	if err != nil {
-		return nil, err
+		return err
 	}
 
-	var res map[string]interface{}
-	err = json.Unmarshal(body, &res)
+	res := &cfResp{}
+	err = utils.Json.Unmarshal(body, res)
 	if err != nil {
-		return nil, err
+		return err
 	}
 
-	result := res["result"].([]interface{})
+	result := res.Result
 	if len(result) > 0 {
-		return result[0].(map[string]interface{}), nil
+		provider.recordId = result[0].ID
+		return nil
 	}
 
-	return nil, nil // 没有找到 DNS 记录
+	return nil
 }
 
-func (provider *ProviderCloudflare) createDNSRecord(zoneID string, domainConfig *DomainConfig, isIPv4 bool) bool {
-	var ipType = "A"
-	var ipAddr = domainConfig.Ipv4Addr
-	if !isIPv4 {
+func (provider *ProviderCloudflare) createDNSRecord(isIPv4 bool) error {
+	var ipType, ipAddr string
+	if isIPv4 {
+		ipType = "A"
+		ipAddr = provider.domainConfig.Ipv4Addr
+	} else {
 		ipType = "AAAA"
-		ipAddr = domainConfig.Ipv6Addr
-	}
-	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records", zoneID)
-	data := map[string]interface{}{
-		"type":    ipType,
-		"name":    domainConfig.FullDomain,
-		"content": ipAddr,
-		"ttl":     60,
-		"proxied": false,
-	}
-	jsonData, _ := json.Marshal(data)
-	_, err := provider.sendRequest("POST", url, jsonData)
-	return err == nil
+		ipAddr = provider.domainConfig.Ipv6Addr
+	}
+
+	de, _ := url.JoinPath(baseEndpoint, provider.zoneId, "dns_records")
+	data := &cfReq{
+		Name:    provider.domainConfig.FullDomain,
+		Type:    ipType,
+		Content: ipAddr,
+		TTL:     60,
+		Proxied: false,
+	}
+
+	jsonData, _ := utils.Json.Marshal(data)
+	_, err := provider.sendRequest("POST", de, jsonData)
+	return err
 }
 
-func (provider *ProviderCloudflare) updateDNSRecord(zoneID string, recordID string, domainConfig *DomainConfig, isIPv4 bool) bool {
-	var ipType = "A"
-	var ipAddr = domainConfig.Ipv4Addr
-	if !isIPv4 {
+func (provider *ProviderCloudflare) updateDNSRecord(isIPv4 bool) error {
+	var ipType, ipAddr string
+	if isIPv4 {
+		ipType = "A"
+		ipAddr = provider.domainConfig.Ipv4Addr
+	} else {
 		ipType = "AAAA"
-		ipAddr = domainConfig.Ipv6Addr
-	}
-	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records/%s", zoneID, recordID)
-	data := map[string]interface{}{
-		"type":    ipType,
-		"name":    domainConfig.FullDomain,
-		"content": ipAddr,
-		"ttl":     60,
-		"proxied": false,
-	}
-	jsonData, _ := json.Marshal(data)
-	_, err := provider.sendRequest("PATCH", url, jsonData)
-	return err == nil
+		ipAddr = provider.domainConfig.Ipv6Addr
+	}
+
+	de, _ := url.JoinPath(baseEndpoint, provider.zoneId, "dns_records", provider.recordId)
+	data := &cfReq{
+		Name:    provider.domainConfig.FullDomain,
+		Type:    ipType,
+		Content: ipAddr,
+		TTL:     60,
+		Proxied: false,
+	}
+
+	jsonData, _ := utils.Json.Marshal(data)
+	_, err := provider.sendRequest("PATCH", de, jsonData)
+	return err
 }
 
 // 以下为辅助方法，如发送 HTTP 请求等
 func (provider *ProviderCloudflare) sendRequest(method string, url string, data []byte) ([]byte, error) {
-	client := &http.Client{}
 	req, err := http.NewRequest(method, url, bytes.NewBuffer(data))
 	if err != nil {
 		return nil, err
 	}
 
-	req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", provider.Secret))
+	req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", provider.secret))
 	req.Header.Add("Content-Type", "application/json")
 
-	resp, err := client.Do(req)
+	resp, err := utils.HttpClient.Do(req)
 	if err != nil {
 		return nil, err
 	}
 	defer func(Body io.ReadCloser) {
 		err := Body.Close()
 		if err != nil {
-			log.Printf("NEZHA>> 无法关闭HTTP响应体流: %s\n", err.Error())
+			log.Printf("NEZHA>> 无法关闭HTTP响应体流: %s", err.Error())
 		}
 	}(resp.Body)
 

pkg/ddns/ddns.go

@@ -1,5 +1,7 @@
 package ddns
 
+import "golang.org/x/net/publicsuffix"
+
 type DomainConfig struct {
 	EnableIPv4 bool
 	EnableIpv6 bool
@@ -10,5 +12,11 @@ type DomainConfig struct {
 
 type Provider interface {
 	// UpdateDomain Return is updated
-	UpdateDomain(domainConfig *DomainConfig) bool
+	UpdateDomain(*DomainConfig) error
+}
+
+func splitDomain(domain string) (prefix string, realDomain string) {
+	realDomain, _ = publicsuffix.EffectiveTLDPlusOne(domain)
+	prefix = domain[:len(domain)-len(realDomain)-1]
+	return prefix, realDomain
 }