Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ucd sonic #489

Merged
merged 26 commits into from
Aug 15, 2023
Merged

Ucd sonic #489

merged 26 commits into from
Aug 15, 2023

Conversation

brucemoran
Copy link
Contributor

name: UCD_SONIC
about: University College Dublin Sonic HPC config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

Working on my end, let me know if anything else required, thanks!

jfy133
jfy133 requested changes Jul 3, 2023
View reviewed changes
conf/ucd_sonic.config Outdated Show resolved Hide resolved
conf/ucd_sonic.config Outdated Show resolved Hide resolved
conf/ucd_sonic.config Show resolved Hide resolved
conf/ucd_sonic.config Outdated Show resolved Hide resolved
docs/ucd_sonic.md Outdated Show resolved Hide resolved
docs/ucd_sonic.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Jul 3, 2023

Sorry for the long delay! Apparently all our notifications for this repo stopped...

@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

nf-core-bot and others added 4 commits July 3, 2023 09:04
@nf-core-bot
[automated] Fix linting with Prettier
b1d15d3
@brucemoran
Update ucd_sonic.md
30f0c11 
Offers sbatch_nxf_creator as an option.
@brucemoran
Merge branch 'master' into UCD_SONIC
7d2bdd4
@brucemoran @jfy133
Update conf/ucd_sonic.config
509b407 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
brucemoran
brucemoran commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@brucemoran brucemoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK

jfy133
jfy133 reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Outstranding questions though

conf/ucd_sonic.config Outdated Show resolved Hide resolved
conf/ucd_sonic.config Show resolved Hide resolved
docs/ucd_sonic.md Outdated Show resolved Hide resolved
brucemoran and others added 3 commits August 15, 2023 15:50
@brucemoran @jfy133
Update conf/ucd_sonic.config
208515d 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@brucemoran @jfy133
Update docs/ucd_sonic.md
01ae9c9 
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@brucemoran
Remove bmoran profile
7e113e2
jfy133
jfy133 approved these changes Aug 15, 2023
View reviewed changes
conf/ucd_sonic.config Show resolved Hide resolved
@jfy133 jfy133 merged commit 93d866a into nf-core:master Aug 15, 2023
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brucemoran @jfy133 @maxulysse @nf-core-bot