Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 1.10.1 #207

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Prepare release 1.10.1 #207

merged 6 commits into from
Oct 6, 2023

Conversation

maxulysse
Copy link
Member

nf-core bump-version 1.10.1

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 588cef6

+| ✅ 147 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.10.1
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: lib/WorkflowFetchngs.groovy
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-06 10:01:29

@drpatelh
Copy link
Member

drpatelh commented Sep 22, 2023 •
edited
Loading

Need to update the CHANGELOG here too and thank everyone for their contributions!

@maxulysse
Copy link
Member Author

Need to update the CHANGELOG here too and thank everyone for their contributions!

I'm just including the 3 of us since this is only TEMPLATE update and small refactoring.
I'll include the whole team for the nf-test POC PR

@maxulysse
Copy link
Member Author

Where are the tests?

@robsyme robsyme mentioned this pull request Oct 2, 2023
Merged
drpatelh
drpatelh approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drpatelh drpatelh merged commit 1436b69 into dev Oct 6, 2023
10 checks passed
@maxulysse maxulysse deleted the prepare-1-10-1_release branch October 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @drpatelh