Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized resources #269

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

optimized resources #269

wants to merge 1 commit into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Feb 6, 2024 •
edited
Loading

No description provided.

@edmundmiller edmundmiller changed the base branch from master to dev February 6, 2024 15:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 384a352

+| ✅ 148 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • nextflow_config - Config manifest.version should end in dev: 1.12.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-06 15:44:18

@nf-core nf-core deleted a comment from github-actions bot Feb 6, 2024
@edmundmiller edmundmiller self-assigned this Feb 6, 2024
adamrtalbot
adamrtalbot reviewed Feb 6, 2024
View reviewed changes
conf/test_full.config
Comment on lines +21 to +44
process {
withName: 'NFCORE_FETCHNGS:SRA:FASTQ_DOWNLOAD_PREFETCH_FASTERQDUMP_SRATOOLS:CUSTOM_SRATOOLSNCBISETTINGS' {
cpus = { 1 * task.attempt }
memory = { 1.GB * task.attempt }
}
withName: 'NFCORE_FETCHNGS:SRA:MULTIQC_MAPPINGS_CONFIG' {
cpus = { 1 * task.attempt }
memory = { 1.GB * task.attempt }
}
withName: 'NFCORE_FETCHNGS:SRA:SRA_FASTQ_FTP' {
cpus = { 1 * task.attempt }
memory = { 1.GB * task.attempt }
}
withName: 'NFCORE_FETCHNGS:SRA:SRA_IDS_TO_RUNINFO' {
cpus = { 1 * task.attempt }
memory = { 1.GB * task.attempt }
}
withName: 'NFCORE_FETCHNGS:SRA:SRA_RUNINFO_TO_FTP' {
cpus = { 1 * task.attempt }
memory = { 1.GB * task.attempt }
}
errorStrategy = 'retry'
maxRetries = 2
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems...optimistic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess platform is an optimist 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. Can we get some proof it works, perhaps with a big test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot left review comments

@mashehu mashehu Awaiting requested review from mashehu

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

@drpatelh drpatelh Awaiting requested review from drpatelh

At least 1 approving review is required to merge this pull request.

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@edmundmiller @adamrtalbot