Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

318 update some modeles for tes compliance #319

Closed
wants to merge 11 commits into from
Closed

318 update some modeles for tes compliance #319

wants to merge 11 commits into from

Conversation

vsmalladi
Copy link

@vsmalladi vsmalladi commented Sep 15, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
    (https://github.com/nf-core/fetchngs/tree/master/.github/CONTRIBUTING.md)
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@vsmalladi vsmalladi linked an issue Sep 15, 2024 that may be closed by this pull request
Update some modeles for TES compliance #318
Open
@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @vsmalladi,

It looks like this pull-request is has been made against the nf-core/fetchngs master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/fetchngs dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 15, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 36dedb8

+| ✅ 155 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   5 tests had warnings |!
-| ❌   2 tests failed       |-

❌ Test failures:

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-16 03:33:32

@vsmalladi vsmalladi changed the base branch from master to dev September 15, 2024 13:08
@vsmalladi vsmalladi closed this Sep 16, 2024
@vsmalladi vsmalladi deleted the 318-update-some-modeles-for-tes-compliance branch September 16, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot Awaiting requested review from adamrtalbot

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update some modeles for TES compliance
2 participants
@vsmalladi @drpatelh