Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

318 update for tes compliance #320

Merged
merged 17 commits into from
Oct 15, 2024
Merged

318 update for tes compliance #320

merged 17 commits into from
Oct 15, 2024

Conversation

vsmalladi
Copy link

@vsmalladi vsmalladi commented Sep 16, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @vsmalladi,

It looks like this pull-request is has been made against the nf-core/fetchngs master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/fetchngs dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d0e3777

+| ✅ 167 tests passed       |+
#| ❔  12 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-15 15:09:53

@vsmalladi vsmalladi changed the base branch from master to dev September 16, 2024 03:57
maxulysse
maxulysse reviewed Oct 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

Linting is failing, but it's ok, I'll finish working up on TEMPLATE sync and then merge this one.
sorry for the delay @vsmalladi

@vsmalladi
Copy link
Author

Great thanks @maxulysse

@maxulysse
Copy link
Member

That looks good to me, but I'm asking an extra set of eyes for safety because of the updates in all the tests

JoseEspinosa
JoseEspinosa approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small formatting suggestion

modules/local/multiqc_mappings_config/main.nf Outdated Show resolved Hide resolved
@maxulysse @JoseEspinosa
Update modules/local/multiqc_mappings_config/main.nf
d0e3777 
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
@vsmalladi
Copy link
Author

Awesome. I think I can update the rest for tea compliance as well

@maxulysse maxulysse merged commit 7544cb9 into dev Oct 15, 2024
64 checks passed
@maxulysse maxulysse deleted the 318-update-for-tes-compliance branch November 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@adamrtalbot adamrtalbot Awaiting requested review from adamrtalbot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsmalladi @maxulysse @JoseEspinosa