Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Switch to github-style admonitions #44

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Switch to github-style admonitions #44

merged 1 commit into from
Jun 13, 2024

Conversation

nictru
Copy link

@nictru nictru commented Jun 13, 2024

As the previous deprecation not was not correctly displayed in the GitHub repo, this PR switches to using GitHub-Style admonitions

@nictru nictru requested a review from maxulysse June 13, 2024 09:07
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --fix
    • Manually resolve anything left from markdownlint .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Copy link

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@nictru
Copy link
Author

nictru commented Jun 13, 2024

The preview looks good now

@maxulysse maxulysse merged commit c2c9728 into dev Jun 13, 2024
0 of 10 checks passed
@maxulysse maxulysse deleted the deprecation branch June 13, 2024 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants