-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better save status #11
Comments
Can you list down steps how to resolve this? i am in |
@vasnt, the implementation for this I was picturing is the have the json for the card compared with the previous json when an editor value changes. If there is a new change, show that there's unsaved changes in the saved status which will then be auto saved with this code. Then, if there's unsaved changes, warn the user that they're about to loose that data. |
@nfoert, if no one is working on this feature, please assign it to me. |
It's all yours @mSaurabh! See my previous comment on this issue for how I was planning to implement it. |
@nfoert My code is ready, but my vs. code formatter has made many formatting changes. Is there a particular formatter you guys use? |
Now I notice that you propably do some changes in JS files. For JS files I recommend |
Formatting changes are fine with me @mSaurabh! Anything major I can fix manually if needed, thanks for working on this! |
… before leaving editor.
@nfoert I have opened my PR.. |
Actually show if there's been unsaved changes in the editor view and warn the user if they try to leave the page with unsaved changes.
The text was updated successfully, but these errors were encountered: