Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better save status #11

Open
nfoert opened this issue Jul 1, 2024 · 10 comments
Open

Better save status #11

nfoert opened this issue Jul 1, 2024 · 10 comments
Assignees
Labels
awaiting merge Awaiting branch merges to be completed client A change to client-side code feature New feature or request good first issue Good for newcomers hacktoberfest A good issue for hacktoberfest 2024

Comments

@nfoert
Copy link
Owner

nfoert commented Jul 1, 2024

Actually show if there's been unsaved changes in the editor view and warn the user if they try to leave the page with unsaved changes.

@nfoert nfoert added feature New feature or request good first issue Good for newcomers client A change to client-side code labels Jul 1, 2024
@vasnt
Copy link
Contributor

vasnt commented Aug 2, 2024

Can you list down steps how to resolve this? i am in

@nfoert
Copy link
Owner Author

nfoert commented Aug 2, 2024

@vasnt, the implementation for this I was picturing is the have the json for the card compared with the previous json when an editor value changes. If there is a new change, show that there's unsaved changes in the saved status which will then be auto saved with this code. Then, if there's unsaved changes, warn the user that they're about to loose that data.

@nfoert nfoert added the hacktoberfest A good issue for hacktoberfest 2024 label Oct 1, 2024
@mSaurabh
Copy link

mSaurabh commented Oct 2, 2024

@nfoert, if no one is working on this feature, please assign it to me.

@nfoert
Copy link
Owner Author

nfoert commented Oct 2, 2024

It's all yours @mSaurabh! See my previous comment on this issue for how I was planning to implement it.

@mSaurabh
Copy link

mSaurabh commented Oct 5, 2024

@nfoert My code is ready, but my vs. code formatter has made many formatting changes. Is there a particular formatter you guys use?

@ar4s
Copy link
Contributor

ar4s commented Oct 5, 2024

@mSaurabh In #67 I have introduced ruff to format Python code and also it is available from VS code as an extension.

@ar4s
Copy link
Contributor

ar4s commented Oct 5, 2024

Now I notice that you propably do some changes in JS files. For JS files I recommend biome - I am in the middle of implementing (#76) but it is many errors and warning to fix so perhaps i will finish that in next week 😂 or change scope of this PR.

@mSaurabh
Copy link

mSaurabh commented Oct 5, 2024

No worries. I can create a PR if yall are ok with those formatting changes. @ar4s @nfoert

@nfoert
Copy link
Owner Author

nfoert commented Oct 5, 2024

Formatting changes are fine with me @mSaurabh! Anything major I can fix manually if needed, thanks for working on this!

mSaurabh added a commit to mSaurabh/cardie-hacktoberfest that referenced this issue Oct 6, 2024
@mSaurabh
Copy link

mSaurabh commented Oct 6, 2024

@nfoert I have opened my PR..

@nfoert nfoert added the awaiting merge Awaiting branch merges to be completed label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting branch merges to be completed client A change to client-side code feature New feature or request good first issue Good for newcomers hacktoberfest A good issue for hacktoberfest 2024
Projects
None yet
Development

No branches or pull requests

4 participants