Skip to content

Commit c162d76

Browse files
authored
[Dev] Add a run directory when developing locally (#1398)
* creates a run directory under build to use when developing locally * add back missing target * add back external file server to mock management target
1 parent de0b70f commit c162d76

File tree

1 file changed

+23
-11
lines changed

1 file changed

+23
-11
lines changed

Makefile

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,19 @@ IMAGE_PATH ?= "/nginx/agent"
3636
TAG ?= ""
3737
NGINX_LICENSE_JWT ?= ""
3838

39-
BUILD_DIR := build
40-
TEST_BUILD_DIR := build/test
41-
CERTS_DIR := build/certs
39+
BUILD_DIR := $(shell pwd)/build
40+
RUN_DIR := $(BUILD_DIR)/run
41+
TEST_BUILD_DIR := $(BUILD_DIR)/test
42+
CERTS_DIR := $(BUILD_DIR)/certs
4243
DOCS_DIR := docs
4344
PROTO_DIR := proto
44-
BINARY_NAME := nginx-agent
45-
PROJECT_DIR = cmd/agent
46-
PROJECT_FILE = main.go
47-
COLLECTOR_PATH ?= /etc/nginx-agent/opentelemetry-collector-agent.yaml
48-
LIB_DIR ?= /var/lib/nginx-agent
49-
DIRS = $(BUILD_DIR) $(TEST_BUILD_DIR) $(BUILD_DIR)/$(DOCS_DIR) $(BUILD_DIR)/$(DOCS_DIR)/$(PROTO_DIR)
45+
BINARY_NAME := nginx-agent
46+
PROJECT_DIR = cmd/agent
47+
PROJECT_FILE = main.go
48+
LOG_PATH ?= $(RUN_DIR)/agent.log
49+
COLLECTOR_PATH ?= $(RUN_DIR)
50+
LIB_DIR ?= $(RUN_DIR)
51+
DIRS = $(BUILD_DIR) $(RUN_DIR) $(TEST_BUILD_DIR) $(BUILD_DIR)/$(DOCS_DIR) $(BUILD_DIR)/$(DOCS_DIR)/$(PROTO_DIR)
5052
$(shell mkdir -p $(DIRS))
5153

5254
VERSION ?= $(shell git describe --match "v[0-9]*" --abbrev=0 --tags)
@@ -202,15 +204,25 @@ run: build ## Run code
202204

203205
dev: ## Run agent executable
204206
@echo "🚀 Running App"
205-
NGINX_AGENT_COLLECTOR_CONFIG_PATH=$(COLLECTOR_PATH) NGINX_AGENT_LIB_DIR=$(LIB_DIR) $(GORUN) -ldflags=$(DEBUG_LDFLAGS) $(PROJECT_DIR)/$(PROJECT_FILE)
207+
touch $(LOG_PATH)
208+
NGINX_AGENT_COLLECTOR_CONFIG_PATH=$(COLLECTOR_PATH)/opentelemetry-collector-agent.yaml \
209+
NGINX_AGENT_COLLECTOR_LOG_LEVEL="DEBUG" \
210+
NGINX_AGENT_COLLECTOR_LOG_PATH=$(COLLECTOR_PATH)/otel.log \
211+
NGINX_AGENT_LIB_DIR=$(LIB_DIR) \
212+
$(GORUN) -ldflags=$(DEBUG_LDFLAGS) $(PROJECT_DIR)/$(PROJECT_FILE)
206213

207214
race-condition-dev: ## Run agent executable with race condition detection
208215
@echo "🏎️ Running app with race condition detection enabled"
209216
$(GORUN) -race $(PROJECT_DIR)/$(PROJECT_FILE)
210217

211218
run-mock-management-grpc-server: ## Run mock management plane gRPC server
212219
@echo "🖲️ Running mock management plane gRPC server"
213-
$(GORUN) test/mock/grpc/cmd/main.go -configDirectory=$(MOCK_MANAGEMENT_PLANE_CONFIG_DIRECTORY) -logLevel=$(MOCK_MANAGEMENT_PLANE_LOG_LEVEL) -grpcAddress=$(MOCK_MANAGEMENT_PLANE_GRPC_ADDRESS) -apiAddress=$(MOCK_MANAGEMENT_PLANE_API_ADDRESS) -externalFileServer=$(MOCK_MANAGEMENT_PLANE_EXTERNAL_FILE_SERVER)
220+
$(GORUN) test/mock/grpc/cmd/main.go \
221+
-configDirectory=$(MOCK_MANAGEMENT_PLANE_CONFIG_DIRECTORY) \
222+
-logLevel=$(MOCK_MANAGEMENT_PLANE_LOG_LEVEL) \
223+
-grpcAddress=$(MOCK_MANAGEMENT_PLANE_GRPC_ADDRESS) \
224+
-apiAddress=$(MOCK_MANAGEMENT_PLANE_API_ADDRESS) \
225+
-externalFileServer=$(MOCK_MANAGEMENT_PLANE_EXTERNAL_FILE_SERVER)
214226

215227

216228
.PHONY: build-test-nginx-plus-and-nap-image

0 commit comments

Comments
 (0)